Write out optical size diagnostic #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test summary 4 476 files 6 902 suites 12m 54s ⏱️ For more details on these failures, see this check. Results for commit 4e655e6. ♻️ This comment has been updated with latest results. |
const char* was ambiguous
sethrj
added a commit
that referenced
this pull request
Jan 29, 2025
* Rename diagnostic for consistency * Add optical size diagnostic * Only add optical loop parameters when running an optical problem * Don't write optical loop input when disabled * Fix app test names * Add assertions for sizes * Account for multithreading * Make initializers more reproducible * Improve debug message and doc * Fix build errors with old GCC/Geant4/nljson (const char* was ambiguous) * Use divisible-into-100 events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor follow-on to #1591. It writes out the optical sizes just like we do the core sizes. I also changed the output key for consistency with the other output diagnostics.