Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Action Space incl. Layouting and BQSKit Integration #204

Merged
merged 20 commits into from
Feb 26, 2024
Merged

Conversation

nquetschlich
Copy link
Collaborator

@nquetschlich nquetschlich commented Feb 26, 2024

This PR

  • adds BQSKit as another source for compilation passes
  • improves the Qiskit.Quantumcircuit.Layout attribute handling, and
  • adds further Qiskit compilation passes (VF2Layout and VF2PostLayout).

nquetschlich and others added 3 commits February 1, 2024 15:02
This PR
- makes sure, that always a valid `Qiskit.QuantumCircuit.layout`
attribute is set after the compilation (even when it is compiled with
non-qiskit compilation passes)
- removes unnecessary sabre layout and routing actions (mapping is still
in there)
- improves the Qiskit O3 optimization action such that it does not
synthesize and map automatically any more
)

To further enhance MQT Predictor by additional supported quantum SDKs,
[BQSKit](https://github.com/BQSKit/bqskit) has been integrated as an
optimization action, synthesis action, and mapping action.

Additionally, the action structure and how it is called has been
improved.

Furthermore, the seeding in the used `gymnasium` environment has been
improved.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Lukas Burgholzer <[email protected]>
@nquetschlich nquetschlich added enhancement New feature or request feature New feature or request minor Part of a minor release labels Feb 26, 2024
@nquetschlich nquetschlich self-assigned this Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 88.35616% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 79.2%. Comparing base (30b471b) to head (23d31fd).

Files Patch % Lines
src/mqt/predictor/rl/PredictorEnv.py 85.0% 10 Missing ⚠️
src/mqt/predictor/rl/helper.py 90.7% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #204     +/-   ##
=======================================
+ Coverage   78.3%   79.2%   +0.9%     
=======================================
  Files         12      12             
  Lines        867     982    +115     
=======================================
+ Hits         679     778     +99     
- Misses       188     204     +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nquetschlich
Copy link
Collaborator Author

resolves #132

@nquetschlich nquetschlich merged commit 98e5428 into main Feb 26, 2024
13 checks passed
@nquetschlich nquetschlich deleted the dev branch February 26, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New feature or request minor Part of a minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant