Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve e2e tests flakiness #1115

Merged
merged 7 commits into from
Feb 21, 2025
Merged

fix: improve e2e tests flakiness #1115

merged 7 commits into from
Feb 21, 2025

Conversation

mas-who
Copy link
Contributor

@mas-who mas-who commented Feb 18, 2025 •
edited
Loading

Done

  • reduce flakiness in e2e tests

QA

  1. Run the LXD-UI:
  2. Perform the following QA steps:
    • Ensure CI passes

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@mas-who mas-who marked this pull request as draft February 20, 2025 08:05
@mas-who mas-who changed the title fix: use ubuntu jammy for github actions fix: improve e2e tests flakiness Feb 20, 2025
@mas-who mas-who mentioned this pull request Feb 20, 2025
Merged
@mas-who mas-who force-pushed the fix-e2e-tests branch 2 times, most recently from 35189b9 to 32a6f04 Compare February 20, 2025 16:05
@MasWho
fix: reduce flakiness for instance panel e2e
2cb6cd6 
Signed-off-by: Mason Hu <[email protected]>
@MasWho
fix: delete images between test retries to prevent image already exis…
b667e76 
…t error

Signed-off-by: Mason Hu <[email protected]>
@MasWho
fix: force stop instance from panel
5d42644 
Signed-off-by: Mason Hu <[email protected]>
@MasWho
fix: make sure address input exists before typing for network forwards
05d7a6e 
Signed-off-by: Mason Hu <[email protected]>
@MasWho
fix: prevent clicking project select button before dom content is loaded
782a923 
Signed-off-by: Mason Hu <[email protected]>
@MasWho
fix: prevent network background activity from affecting tests
0f27aab 
Signed-off-by: Mason Hu <[email protected]>
@MasWho
fix: use fill for network forward tests
dfc4845 
Signed-off-by: Mason Hu <[email protected]>
@mas-who mas-who marked this pull request as ready for review February 20, 2025 16:38
edlerd
edlerd approved these changes Feb 21, 2025
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks for making the tests more stable.

@mas-who mas-who merged commit edb5202 into canonical:main Feb 21, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mas-who @webteam-app @edlerd @MasWho