fix: reduce flakiness for instance panel e2e

Signed-off-by: Mason Hu <[email protected]>
canonical · Feb 20, 2025 · 0199e37 · 0199e37
1 parent e751537
commit 0199e37
Showing 1 changed file with 15 additions and 2 deletions.
diff --git a/tests/helpers/instancePanel.ts b/tests/helpers/instancePanel.ts
@@ -28,7 +28,7 @@ export const startInstanceFromPanel = async (page: Page, instance: string) => {
   });
   const startButton = instanceDetailPanel.locator("css=button[title=Start]");
   await startButton.click();
-  await page.waitForSelector(`text=Instance ${instance} started.`);
+  await checkInstanceStatus(page, instance, "Running");
 };
 
 export const stopInstanceFromPanel = async (page: Page, instance: string) => {
@@ -43,7 +43,7 @@ export const stopInstanceFromPanel = async (page: Page, instance: string) => {
     hasText: "Stop",
   });
   await confirmStopButton.click();
-  await page.waitForSelector(`text=Instance ${instance} stopped.`);
+  await checkInstanceStatus(page, instance, "Stopped");
 };
 
 export const navigateToInstanceDetails = async (
@@ -62,3 +62,16 @@ export const navigateToInstanceDetails = async (
   });
   await expect(instanceDetailTitle).toBeVisible();
 };
+
+export const checkInstanceStatus = async (
+  page: Page,
+  instance: string,
+  status: string,
+) => {
+  await page.waitForLoadState("networkidle");
+  await gotoURL(page, "/ui/");
+  await openInstancePanel(page, instance);
+  const sidePanel = page.getByLabel("Side panel");
+  const statusRow = sidePanel.getByRole("row", { name: "Status" });
+  await expect(statusRow.getByRole("cell", { name: status })).toBeVisible();
+};