Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all tests for backports or when there are test changes #882

Closed
wants to merge 5 commits into from
Closed

Run all tests for backports or when there are test changes #882

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6d89b7e
Fix nightly job
petrutlucian94 Dec 6, 2024
593936a
Apply Docker iptables workaround
petrutlucian94 Dec 6, 2024
244335e
Fix test_node_cleanup_new_containerd_path test
petrutlucian94 Dec 9, 2024
72d17d3
Fix linter errors
petrutlucian94 Dec 9, 2024
66221db
Run all tests for backports or when there are test changes
petrutlucian94 Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,17 @@ jobs:
TEST_VERSION_UPGRADE_MIN_RELEASE: "1.31"
TEST_MIRROR_LIST: '[{"name": "ghcr.io", "port": 5000, "remote": "https://ghcr.io", "username": "${{ github.actor }}", "password": "${{ secrets.GITHUB_TOKEN }}"}, {"name": "docker.io", "port": 5001, "remote": "https://registry-1.docker.io", "username": "", "password": ""}, {"name": "rocks.canonical.com", "port": 5002, "remote": "https://rocks.canonical.com/cdk"}]'
run: |
cd tests/integration && sg lxd -c 'tox -e integration -- --tags pull_request'
tags="pull_request"
# Run all tests if there are test changes. In case of a PR, we'll
# get a merge commit that includes all changes.
if git diff HEAD HEAD~1 --name-only | grep "tests/"; then
tags="weekly"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be up_to_weekly otherwise only the weekly tags are executed. Same below.
See

k8s-snap/tests/integration/tests/test_util/tags.py

Line 13 in aabe445

combine_tags("up_to_nightly", PULL_REQUEST, NIGHTLY)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!

fi
# Run all tests on backports.
if echo ${{ github.base_ref }} | grep "release-"; then
tags="weekly"
fi
cd tests/integration && sg lxd -c 'tox -e integration -- --tags $tags'
- name: Prepare inspection reports
if: failure()
run: |
Expand Down
Loading