Run all tests for backports or when there are test changes #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The runner labels used by the nightly job are not correctly evaluated. We'll fix this by switching to the newly added one-string node labels.
The containerd base dir setting is currently ignored when joining nodes. The reason is that yaml parser ignores a struct field which is marked as private. Making it public fixes the issue. At the same time, the test expects the default containerd folders to be missing when configured to use a different base dir. However, the tests are currently placing the registry settings in /etc/containerd. We also get an empty /run/containerd folder. For now, we'll update the test to ignore these folders. There's also an os.path.join call that doesn't produce the expected result if the last element is an absolute path, we'll need to remove a slash when constructing the paths.
We're adding a few checks to the integration tests workflow. We'll use the "weekly" tag in case of backports (targeting the release-* branches) and whenever there are test changes.
|
Based on #876, I'll mark this PR as done once the other one merges. |
bschimke95
reviewed
Dec 10, 2024
There was a problem hiding this comment.
Thanks @petrutlucian94 - minor change, then we can merge this.
| # Run all tests if there are test changes. In case of a PR, we'll | ||
| # get a merge commit that includes all changes. | ||
| if git diff HEAD HEAD~1 --name-only | grep "tests/"; then | ||
| tags="weekly" |
There was a problem hiding this comment.
this needs to be up_to_weekly otherwise only the weekly tags are executed. Same below.
See
There was a problem hiding this comment.
Good point, thanks!
|
Closed in favor of #876 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're adding a few checks to the integration tests workflow. We'll use the "weekly" tag in case of backports (targeting the release-* branches) and whenever there are test changes.