Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify list of ExtraSANs for the kube-apiserver certs #263

Merged
merged 23 commits into from
Mar 26, 2024
Merged

Specify list of ExtraSANs for the kube-apiserver certs #263

merged 23 commits into from
Mar 26, 2024

Conversation

eaudetcobello
Copy link
Contributor

No description provided.

@eaudetcobello eaudetcobello force-pushed the KU-490/extrasans-certs branch from 78246ca to bdd692f Compare March 21, 2024 15:00
neoaggelos
neoaggelos suggested changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, going in the right direction and I like how the unit tests give us confidence that things are working. Left some comments for things to improve

@eaudetcobello eaudetcobello force-pushed the KU-490/extrasans-certs branch from ea5d086 to d6b8136 Compare March 22, 2024 15:42
@eaudetcobello eaudetcobello marked this pull request as ready for review March 22, 2024 19:07
@eaudetcobello eaudetcobello requested a review from a team as a code owner March 22, 2024 19:07
@eaudetcobello eaudetcobello changed the title [WIP] Specify list of ExtraSANs for the kube-apiserver certs Specify list of ExtraSANs for the kube-apiserver certs Mar 22, 2024
neoaggelos
neoaggelos suggested changes Mar 23, 2024
View reviewed changes
Copy link
Contributor

@neoaggelos neoaggelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @eaudetcobello, looks better, did another pass

bschimke95
bschimke95 reviewed Mar 25, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work so far, some final comments and we are good

bschimke95
bschimke95 approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

Package Line Rate
github.com/canonical/k8s/api/v1 48%
github.com/canonical/k8s/cmd/k8s 28%
github.com/canonical/k8s/cmd/util 14%
github.com/canonical/k8s/pkg/client/dqlite 44%
github.com/canonical/k8s/pkg/component 10%
github.com/canonical/k8s/pkg/k8sd/api 2%
github.com/canonical/k8s/pkg/k8sd/database 48%
github.com/canonical/k8s/pkg/k8sd/pki 55%
github.com/canonical/k8s/pkg/k8sd/setup 70%
github.com/canonical/k8s/pkg/k8sd/types 68%
github.com/canonical/k8s/pkg/proxy 6%
github.com/canonical/k8s/pkg/snap 15%
github.com/canonical/k8s/pkg/snap/util 90%
github.com/canonical/k8s/pkg/utils 32%
github.com/canonical/k8s/pkg/utils/control 100%
github.com/canonical/k8s/pkg/utils/errors 100%
github.com/canonical/k8s/pkg/utils/k8s 69%
Summary 32% (1654 / 5132)

@kwmonroe kwmonroe merged commit 15289b0 into main Mar 26, 2024
13 checks passed
@kwmonroe kwmonroe deleted the KU-490/extrasans-certs branch March 26, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bschimke95 bschimke95 bschimke95 approved these changes

@neoaggelos neoaggelos Awaiting requested review from neoaggelos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eaudetcobello @neoaggelos @bschimke95 @kwmonroe