Remove dead code and add test for SeparateSANs

src/k8s/pkg/utils/certificate.go

@@ -2,19 +2,17 @@ package utils
 
 import (
 	"net"
-	"strings"
 )
 
-func GetExtraSANsFromString(extraSANs string) []string {
-	// TODO: Add validation for the extraSANs
-	return strings.Split(extraSANs, ",")
-}
-
 func SeparateSANs(extraSANs []string) ([]net.IP, []string) {
 	var ipSANs []net.IP
 	var dnsSANs []string
 
 	for _, san := range extraSANs {
+		if san == "" {
+			continue
+		}
+
 		if ip := net.ParseIP(san); ip != nil {
 			ipSANs = append(ipSANs, ip)
 		} else {

src/k8s/pkg/utils/certificate_test.go

@@ -0,0 +1,31 @@
+package utils_test
+
+import (
+	"testing"
+
+	"github.com/canonical/k8s/pkg/utils"
+
+	. "github.com/onsi/gomega"
+)
+
+func TestSeparateSANs(t *testing.T) {
+	tests := []string{"192.168.0.1", "::1", "cluster.local", "kubernetes.svc.local", "", "2001:db8:0:1:1:1:1:1"}
+
+	g := NewWithT(t)
+	gotIPs, gotDNSs := utils.SeparateSANs(tests)
+
+	// Convert cert.IPAddresses to a slice of string representations
+	ips := make([]string, len(gotIPs))
+	for i, ip := range gotIPs {
+		ips[i] = ip.String()
+	}
+
+	g.Expect(len(ips)).To(Equal(3))
+	g.Expect(ips).To(ContainElement("192.168.0.1"))
+	g.Expect(ips).To(ContainElement("::1"))
+	g.Expect(ips).To(ContainElement("2001:db8:0:1:1:1:1:1"))
+
+	g.Expect(len(gotDNSs)).To(Equal(2))
+	g.Expect(gotDNSs).To(ContainElement("cluster.local"))
+	g.Expect(gotDNSs).To(ContainElement("kubernetes.svc.local"))
+}