Performance Test workload (2) #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultCurrent status |
louiseschmidtgen
changed the base branch from
master
to
KU-1866/performance-test
louiseschmidtgen
force-pushed
the
KU-1874/performance-workload
branch
from
545a749 to
cc45bae
Compare
louiseschmidtgen
changed the base branch from
KU-1866/performance-test
to
master
louiseschmidtgen
force-pushed
the
KU-1874/performance-workload
branch
from
cc45bae to
5df8323
Compare
There was a problem hiding this comment.
Great work! Thanks a lot @louiseschmidtgen! Overall LGTM, just some minor comments and questions. Feel free to ignore the nits.
addyess
reviewed
Nov 13, 2024
| name: secret-{{.Replica}} | ||
| type: Opaque | ||
| data: | ||
| password: Zm9vb29vb29vb29vb29vbwo= |
There was a problem hiding this comment.
⚡ echo "Zm9vb29vb29vb29vb29vbwo=" | base64 -d
fooooooooooooooo
addyess
reviewed
Nov 13, 2024
Comment on lines
+165
to
+166
| if ">" in " ".join(command): | ||
| command_str = " ".join(command) |
There was a problem hiding this comment.
The shlex.join doesn't work with special characters so if my command has a ">" in it I am doing a regular join.
addyess
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance Test Workload
There are two load tests:
On the cluster an api-intensive job is launched using kube-burner.
This test creates configmaps and secrets and deletes them.
While the load test runs, pidstat is used to get metrics on CPU, MEM, IO reads and writes and output those files for each node.
This is the start of such a metrics file:
This PR should be merged after #197
Note for reviewers
Popen is necessary to run the metrics collection command in the background.