-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance Test Parse Metrics (3) #200
Conversation
Benchmark Result
Current status
|
cc45bae
to
5df8323
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of my comments are around sourcing of various files. I don't quite know how to review more than the logic bits of the rscript which looks valid enough
@@ -0,0 +1,73 @@ | |||
#!/usr/bin/env Rscript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not familiar with r-script. Did you pull this from somewhere else? Should we be vendoring this into the project or can it be sourced from elsewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this is my magic, I used to work for R :)
5fed75a
to
57438b0
Compare
cd test/performance | ||
mkdir -p ./results/base-code | ||
sg lxd -c 'tox -e performance' | ||
- name: Run Performance test for v1.1.11 snap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, why are you specifically testing v1.1.11? What's special about this version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Performance Test Parse Metrics
This PR takes care of parsing the metrics from the load test (single & three-node) and uploading the results to an artifact.
(GH does not allow uploading images to GH comments- this was the original plan).
We generate the following files & directories:
The test creates another directory for the single-node comparison:
The script creates graphs for cpu, mem, io reads and writes for all files matching a pattern in a directory.
Here is an example for the head's 3 node cpu performance:
(Kube-burner sleeps for 60 seconds before starting the test)
Here is an example for the single-node io writes:
These can be retrieved from the CI run's artifact.
Depends on: #199