Performance Test Set-up (1) #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultCurrent status |
HomayoonAlimohammadi
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Really amazing job @louiseschmidtgen! I tried to go through it as accurate as I could, and LGTM! It should have been such a huge effort to prepare this PR. Wonderful job!
eaudetcobello
requested changes
Nov 11, 2024
eaudetcobello
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance Test
The performance test spins up three lxd containers that join a cluster. Currently, this cluster consists of three control planes. In a follow-up to this PR, kube-burner will run a load-test on the cluster and the resulting metrics are to be displayed as a comment on any future opened PRs.
Set-up
This PR sets up the harness and gh action for the performance test.
These k8s-dqlite combinations get tested on every test:
For simplification, we could opt to run the test on
v1.1.11andv1.2.0only with the published snap (not swapping out the dqlite version).Note
Tests are not run as a matrix but in sequence as the collected metrics will be turned into graphs at the end of the workflow.
This test set-up is similar to the k8s-snap integration test. The test is not part of that suite as it is designed as a performance measurement tool of the k8s-dqlite code. It is a tool to directly compare the performance improvements in PRs against the code in master. The test could be extended for microk8s. For those reasons the correct location for this test is in k8s-dqlite.