Merge LogStructured in SQLLog #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #193 |
BenchmarkResultsCurrent status |
This is used to help move bits from logstructured to sqllog in an incremental fashion
I did not change the query yet, but it should be done as now the list query does not need to return the prev value
After all, the data structure was never a Log Structured.
marco6
force-pushed
the
KU-1750/merge-logstructured-and-sqllog
branch
from
e4c34ed to
ba2a7c4
Compare
|
I rebased on top of |
|
Dropped dependency from #193 |
louiseschmidtgen
approved these changes
Nov 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the functionality from LogStructured into SQLLog and removes LogStructured.
There are many reasons for this change but the most important one is the lack of a real separation between the two structs, making LogStructured a mere translation layer which adds no useful functionality (and actually acts as a limitation, forcing the implementation to be sub-optimal).
The PR is quite big, but each commit takes care of a single aspect of the transition, making it hopefully possible to perform a review.
Wherever made sense the PR also takes the opportunity to make some of the sub-optimal things better both in term of correctness and in terms of memory footprint/speed (for example avoiding some useless copy-paste or some useless memory allocation).
Some part of this PR (namely, the
List/Getquery) could be improved/made simpler, however this PR does not attempt to do that, so that it should be compatible with other outstanding PRs.As a last note, the write path and the indexes do not change, so this PR is compatible with all existing versions.