Emulated etcd version #211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarkResultsCurrent status |
berkayoz
reviewed
Dec 10, 2024
HomayoonAlimohammadi
approved these changes
Dec 11, 2024
| if r.Limit != 0 { | ||
| return nil, fmt.Errorf("unexpected limit: want 0, got %d", r.Limit) | ||
| if r.Limit != 0 && len(r.RangeEnd) != 0 { | ||
| err := fmt.Errorf("invalid combination of rangeEnd and limit, limit should be 0 got %d", r.Limit) |
There was a problem hiding this comment.
Maybe we can change this to a named return (probably in another PR). Because IMO it's easy to miss this and just return fmt.Errorf(...) which won't be caught in the defer.
|
See https://github.com/canonical/k8s-dqlite/pull/212/files#r1879804010, emulatedEtcdVersion is implemented in the linked PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emulated etcd version
Support for etcd version check that evaluates whether RequestWatchProgress is supported by the current version of etcd endpoint from status request: https://github.com/kubernetes/kubernetes/blob/beb696c2c9467dbc44cbaf35c5a4a3daf0321db3/staging/src/k8s.io/apiserver/pkg/storage/feature/feature_support_checker.go#L157
Affected upstream k8s features:
ConsistentListFromCache,WatchList.Backport of k3s-io/kine#316.
This PR defines an emulated etcd version that signifies the RequestWatchProgress is not yet supported. Only once k8s-dqlite supports WatchProgressRequests we can bump the version to signal the feature's support.
Tested with 1.32 rc: https://github.com/canonical/k8s-dqlite/actions/runs/12237343236