Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: release workflow clean changes after creating PR #1084

Closed
wants to merge 1 commit into from
Closed

fix: release workflow clean changes after creating PR #1084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,7 @@ jobs:
if [ "${release_required}" == "true" ]; then
echo "Updating installation script for ${binary}, version: ${version}"

git checkout master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't we already at master here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only in the first iteration

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #1089, we'll be releasing them together. We can benefit from using one PR to update both files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I will close this one as it improves the code that will be deleted.

target_branch="chore/bump-${binary}-installation-script-to-v${version}"
git fetch origin "${target_branch}" || true
git checkout "${target_branch}" || git checkout -b "${target_branch}"
Expand Down