fix: release workflow clean changes after creating PR #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatejVukosav
force-pushed
the
fix--release-workflow-clean-changes-after-creating-PR
branch
from
644b57f to
21af1fe
Compare
MatejVukosav
force-pushed
the
fix--release-workflow-clean-changes-after-creating-PR
branch
from
21af1fe to
efacace
Compare
miraclx
reviewed
Jan 31, 2025
| @@ -375,6 +375,7 @@ jobs: | |||
| if [ "${release_required}" == "true" ]; then | |||
| echo "Updating installation script for ${binary}, version: ${version}" | |||
|
|
|||
| git checkout master | |||
There was a problem hiding this comment.
aren't we already at master here?
There was a problem hiding this comment.
Only in the first iteration
There was a problem hiding this comment.
With #1089, we'll be releasing them together. We can benefit from using one PR to update both files.
There was a problem hiding this comment.
Cool, I will close this one as it improves the code that will be deleted.
|
Replaced with single PR for both binaries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[product] short description
Clean state after PR is created for installation scripts so each loop does not use changes from previous loop.
Test plan
Documentation update
None