Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reblocking TDR/DRS VCFs #1463

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kshakir
Copy link
Contributor

@kshakir kshakir commented Jan 5, 2025

Description

When a DRS URI is used with the ReblockGVCF WDL, the workflow fails because Cromwell's basename function does not support DRS. Recently, instead of receiving GCS URIs for our samples from the Broad's Genomics Platform, our group received DRS URIs for our files stored in TDR. When run with the existing ReblockGVCF workflow in 642e3f2, the WDL basename calls on DRS URIs produce errors as discussed in this Terra Support post: https://support.terra.bio/hc/en-us/community/posts/4405396480027

This PR changes the workflow to use bash's basename instead of WDL's basename during ReblockGVCF.


Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP team by tagging @broadinstitute/warp-admins in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

@dsde-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@jessicaway
Copy link
Member

test this please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants