PD-2559andPD-2558: UMI filtering and cell barcode correction #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Idedup:1MM_CR and soloUMIfiltering:MultiGeneUMI_CR
|
Remember to squash merge! |
aawdeh
changed the title
|
Remember to squash merge! |
|
Remember to squash merge! |
Validation Results: |
added Uniform as default multimapper option
|
Remember to squash merge! |
Validation Results: |
|
Remember to squash merge! |
Validation Results: |
ekiernan
approved these changes
Apr 24, 2024
|
retest this please |
1 similar comment
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined two tickets into one to test out changes and merge changes combined
Tackling both UMI filtering and cell barcode correction
Changed/Added starsolo parameters:
soloCBmatchWLtypeis now set to1MM_multisoloUMIdedupis now set to1MM_CRsoloUMIfilteringis now set toMultiGeneUMI_CRSmart tests failed on: dev_10k_pbmc_downsampled, pbmc_human_v3, mouse_v2_snRNA_example and snRNA_mouse_v2_snRNA_example
Notebook to compare failed smart tests: https://app.terra.bio/#workspaces/warp-pipelines/Multiome-test-workspace/analysis/launch/PD2559_PD2558_umi_filtering_and_cell_barcode_correction.ipynb?mode=edit
Description
Give your PR a concise yet descriptive title.
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Mention any issues fixed, addressed, or otherwise related to this pull request, including issue numbers or hard links for issues in other repos.
You can delete these instructions once you have written your PR description.
Checklist
If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP documentation team by tagging either @ekiernan or @kayleemathews in a comment on this PR.