Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Action to Validate Changelogs #1262

Merged
merged 14 commits into from
Apr 13, 2024

Conversation

kevinpalis
Copy link
Contributor

@kevinpalis kevinpalis commented Apr 12, 2024

Description

This PR adds a GH actions to validate changelogs.
One of the pain points in Jenkins is that you need to look through the output logs to see what the error is. This is addressed here in two ways:

  1. Everything runs in Github via actions and you won't need to VPN to access Jenkins
  2. All the information on the validation errors are added by a bot as a comment to this PR, ie. no need to go through logs

Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP documentation team by tagging either @ekiernan or @kayleemathews in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

Copy link

Remember to squash merge!

Copy link

Remember to squash merge!

Copy link

Remember to squash merge!

Copy link

Remember to squash merge!

Copy link

Remember to squash merge!

Copy link

Remember to squash merge!

Copy link

Remember to squash merge!

Copy link

Remember to squash merge!

Copy link

Remember to squash merge!

Copy link

Remember to squash merge!

Copy link

Remember to squash merge!

Copy link

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
BuildIndices.wdl and BuildIndices.changelog.md do not have matching versions
Some WDLs or changelog files need updating. See output for details.

Copy link

Remember to squash merge!

Copy link

Validation Results:


Copy link

Remember to squash merge!

Copy link

Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
BuildIndices.wdl and BuildIndices.changelog.md do not have matching versions
Some WDLs or changelog files need updating. See output for details.
validation_failed

@kevinpalis kevinpalis changed the title Attempting to finally trigger this with a PR Github Action to Validate Changelogs Apr 12, 2024
Copy link

Remember to squash merge!

Copy link

Validation Results:

basename: missing operand
Try 'basename --help' for more information.
Comparing versions and changelogs for pipelines that differ from the versions on 'origin/develop':
All WDLs and changelog files appear to be valid for this release.

@kevinpalis kevinpalis merged commit ab53484 into develop Apr 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants