Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address some clippy lints #66

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Address some clippy lints #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06ae8e8
boomerang: Remove unnecessary clones
rillian Jul 16, 2024
b78057f
Use const u8::MAX instead of calling max_value()
rillian Jul 16, 2024
34e5f18
cargo fmt
rillian Jul 16, 2024
273a3d5
Merge branch 'main' into clippy
rillian Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion acl/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ impl<A: ACLConfig> KeyPair<A> {
pub fn affine_from_bytes_tai(bytes: &[u8]) -> sw::Affine<A> {
use sha3::{Digest, Sha3_256};

for i in 0..=u8::max_value() {
for i in 0..=u8::MAX {
let mut sha = Sha3_256::new();
Digest::update(&mut sha, bytes);
Digest::update(&mut sha, [i]);
Expand Down
4 changes: 2 additions & 2 deletions boomerang/src/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,8 @@ pub struct SpendVerifyM3<B: BoomerangConfig> {
impl<B: BoomerangConfig> Clone for SpendVerifyM3<B> {
fn clone(&self) -> Self {
Self {
comm: self.comm.clone(),
sig_commit: self.sig_commit.clone(),
comm: self.comm,
sig_commit: self.sig_commit,
id_1: self.id_1,
verifying_key: self.verifying_key,
tag_key: self.tag_key,
Expand Down
2 changes: 1 addition & 1 deletion pedersen/src/pedersen_config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ impl<P: PedersenConfig> PedersenComm<P> {
pub fn affine_from_bytes_tai(bytes: &[u8]) -> sw::Affine<P> {
use sha3::{Digest, Sha3_256};
// Try a deterministic sequence of hashes to find a valid point.
for i in 0..=u8::max_value() {
for i in 0..=u8::MAX {
let mut sha = Sha3_256::new();
Digest::update(&mut sha, bytes);
Digest::update(&mut sha, [i]);
Expand Down
Loading