Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address some clippy lints #66

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Address some clippy lints #66

merged 4 commits into from
Jul 18, 2024

Conversation

rillian
Copy link
Contributor

@rillian rillian commented Jul 16, 2024

Minor code cleanup

rillian added 2 commits July 16, 2024 10:09
@rillian
boomerang: Remove unnecessary clones
06ae8e8 
These types implement copy, so the explicit clone isn't necessary.
@rillian
Use const u8::MAX instead of calling max_value()
b78057f 
Addresses a clippy lint and may optimize better.
@rillian rillian requested a review from claucece July 16, 2024 17:14
@rillian rillian self-assigned this Jul 16, 2024
@rillian rillian requested a review from ankeleralph July 17, 2024 16:34
ankeleralph
ankeleralph approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@ankeleralph ankeleralph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

@rillian rillian merged commit d1a0502 into main Jul 18, 2024
3 of 4 checks passed
@rillian rillian deleted the clippy branch July 18, 2024 14:49
@rillian rillian mentioned this pull request Jul 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankeleralph ankeleralph ankeleralph approved these changes

@claucece claucece Awaiting requested review from claucece

Assignees

@rillian rillian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rillian @ankeleralph