Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request parent model implementation #426

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Request parent model implementation #426

merged 1 commit into from
Nov 13, 2023

Conversation

Simurgan
Copy link
Member

This pr includes request parent model implementation, its methods, and the unit tests.
I have not tested the implementation in the prod environment, tested only in the local environment.
Everything works well and all tests regarding this implementation passes in the local environment.
Successful merge of this pull request closes #399

@Simurgan Simurgan added priority: critical This issue requires immediate attention to prevent major issues or disruptions. size: medium Requires moderate effort and may take several days to a week to complete. difficulty: moderate Requires more than basic skills and knowledge, and may require research or collaboration to complete type: implementation This issue is related to implementation backend issues related to backend labels Nov 13, 2023
@Simurgan Simurgan self-assigned this Nov 13, 2023
@Simurgan Simurgan linked an issue Nov 13, 2023 that may be closed by this pull request
Request Class Implemenation #399
Closed
3 tasks
@Simurgan Simurgan changed the base branch from main to backend November 13, 2023 16:37
Bera0422
Bera0422 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@Bera0422 Bera0422 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementations regarding the request parent class seems complete. It can be merged after fixing the test failures.

@Simurgan Simurgan mentioned this pull request Nov 13, 2023
Merged
@Simurgan
Copy link
Member Author

Failed tests will be handled in #427 . I am mergeing this pull request

@Simurgan Simurgan merged commit 38db4d4 into backend Nov 13, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bera0422 Bera0422 Bera0422 approved these changes

@ArslanArdavic ArslanArdavic Awaiting requested review from ArslanArdavic

Assignees

@Simurgan Simurgan

Labels
backend issues related to backend difficulty: moderate Requires more than basic skills and knowledge, and may require research or collaboration to complete priority: critical This issue requires immediate attention to prevent major issues or disruptions. size: medium Requires moderate effort and may take several days to a week to complete. type: implementation This issue is related to implementation
Projects
None yet
Milestone
CMPE451 Customer Milestone 2: Present...
Development

Successfully merging this pull request may close these issues.

Request Class Implemenation
2 participants
@Simurgan @Bera0422