Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Class Implemenation #399

Closed
3 tasks done
ArslanArdavic opened this issue Nov 7, 2023 · 3 comments · Fixed by #426
Closed
3 tasks done

Request Class Implemenation #399

ArslanArdavic opened this issue Nov 7, 2023 · 3 comments · Fixed by #426
Assignees
@Simurgan
Labels
backend issues related to backend difficulty: moderate Requires more than basic skills and knowledge, and may require research or collaboration to complete priority: medium This issue should be addressed in a reasonable timeframe. size: small Can be completed quickly and without significant effort. type: implementation This issue is related to implementation
Milestone
CMPE451 Customer ...

Comments

@ArslanArdavic
Copy link
Contributor

ArslanArdavic commented Nov 7, 2023 •
edited by Simurgan
Loading

Issue Description

Request Class/Model should be implemented according to the Class Diagram.

NOTE
-This Implementation requires modifications/augmentations within Reviewer class as explained here.

Steps

  • Implementing the attributes
  • Implementing the related functions
  • Writing and running unit tests

Deadline for the Issue

13.11.2023 - Monday - 23.59
@ArslanArdavic ArslanArdavic added priority: medium This issue should be addressed in a reasonable timeframe. size: small Can be completed quickly and without significant effort. difficulty: moderate Requires more than basic skills and knowledge, and may require research or collaboration to complete type: implementation This issue is related to implementation backend issues related to backend labels Nov 7, 2023
@ArslanArdavic
Copy link
Contributor Author

Eventually this class will be requested from front-end application.
So it may be a good idea to do following tasks, right after implenting this class. ,

  • Defining related API endpoints
  • Writing views for handling requests
  • Testing code above

We may consider opening GET/POST/PUT API Implementation issues.
Dear @Bera0422 , what do you think?

Simurgan added a commit that referenced this issue Nov 13, 2023
@Simurgan
implement request model and its tests, closes #399
4d6fcce
@Simurgan Simurgan mentioned this issue Nov 13, 2023
Merged
@Simurgan Simurgan linked a pull request Nov 13, 2023 that will close this issue
Request parent model implementation #426
Merged
@Simurgan
Copy link
Member

@ArslanArdavic I think all your abouve comments and suggestions concern only the reviewrequest model, since the request model is a parent model. If you think there is something wrong, please let me know so I can start to work on it immediately.

@Simurgan
Copy link
Member

The PR has been merged. I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Simurgan Simurgan

Labels
backend issues related to backend difficulty: moderate Requires more than basic skills and knowledge, and may require research or collaboration to complete priority: medium This issue should be addressed in a reasonable timeframe. size: small Can be completed quickly and without significant effort. type: implementation This issue is related to implementation
Projects
None yet
Milestone
CMPE451 Customer Milestone 2: Present...
Development

Successfully merging a pull request may close this issue.

Request parent model implementation bounswe/bounswe2023group9
3 participants
@Simurgan @Bera0422 @ArslanArdavic