Fixes issue 2627: Use cache db for BanManager #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v0.x.x #2635 +/- ##
==========================================
+ Coverage 88.12% 88.45% +0.33%
==========================================
Files 155 155
Lines 15096 15181 +85
==========================================
+ Hits 13303 13429 +126
+ Misses 1793 1752 -41
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hewison-chris
force-pushed
the
issue2627_banned_cache_db
branch
from
56bf640 to
9e94e2c
Compare
mkykadir
reviewed
Nov 3, 2021
hewison-chris
force-pushed
the
issue2627_banned_cache_db
branch
from
9e94e2c to
dc94b06
Compare
mkykadir
reviewed
Nov 3, 2021
hewison-chris
force-pushed
the
issue2627_banned_cache_db
branch
2 times, most recently
from
6a909f1 to
c91c617
Compare
Geod24
reviewed
Nov 5, 2021
hewison-chris
force-pushed
the
issue2627_banned_cache_db
branch
from
c91c617 to
ebe4586
Compare
Geod24
reviewed
Nov 5, 2021
hewison-chris
force-pushed
the
issue2627_banned_cache_db
branch
3 times, most recently
from
f3db927 to
78f2529
Compare
|
|
hewison-chris
force-pushed
the
issue2627_banned_cache_db
branch
from
78f2529 to
57ccdf4
Compare
To ease maintenance and support of Agora it is desirable to have the info used by BanManager in the cache db rather than a binary file. The io unit test for BanManager is also removed.
hewison-chris
force-pushed
the
issue2627_banned_cache_db
branch
from
57ccdf4 to
5306dc9
Compare
Geod24
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace file storage with database tables in cache db.