Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace banned.dat with table in cache.db #2627

Closed
hewison-chris opened this issue Nov 3, 2021 · 0 comments · Fixed by #2635
Closed

Replace banned.dat with table in cache.db #2627

hewison-chris opened this issue Nov 3, 2021 · 0 comments · Fixed by #2635
Assignees
Labels
type-enhancement An improvement of existing functionalities type-refactoring An improvement on existing code without visible functional change

Comments

@hewison-chris
Copy link
Contributor

Before cache.db existed a binary file named banned.dat was created to persist the list of nodes that have failed to respond to a number of requests. It was later updated to also include the validators which are whitelisted so that they are not banned. To make it easier to maintain and query the current state of banned and whitelisted nodes, we should store this in the cache.db.
As a side effect this should also fix an issue we are seeing in our PROD environment where nodes are not able to fetch unknown txs. (#2603)

@hewison-chris hewison-chris added type-enhancement An improvement of existing functionalities type-refactoring An improvement on existing code without visible functional change labels Nov 3, 2021
@hewison-chris hewison-chris self-assigned this Nov 3, 2021
@hewison-chris hewison-chris added this to the 5. CoinNet release milestone Nov 3, 2021
@hewison-chris hewison-chris linked a pull request Nov 3, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement An improvement of existing functionalities type-refactoring An improvement on existing code without visible functional change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant