-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-7317][Web] Clean up old components #12862
base: main
Are you sure you want to change the base?
Conversation
…d-components-on-web' into pm-7317-clean-up-old-components-on-web
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12862 +/- ##
==========================================
- Coverage 34.95% 34.86% -0.09%
==========================================
Files 2977 2974 -3
Lines 90596 90373 -223
Branches 16980 16921 -59
==========================================
- Hits 31671 31513 -158
+ Misses 56468 56445 -23
+ Partials 2457 2415 -42 ☔ View full report in Codecov by Sentry. |
…d-components-on-web' into pm-7317-clean-up-old-components-on-web
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved platform changes
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-7317
📔 Objective
When all marketing content has been changed to use the new Trial Initiation flow, we can remove the obsolete components:
TrialInitiationComponent
app-registration-form
Guard implemented in https://bitwarden.atlassian.net/browse/PM-7373
In addition, we should redirect /register to /signup.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes