Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(email-verification-feature-flag): [PM-7882] Email Verificati… #12718

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Patrick-Pimentel-Bitwarden
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-7326

📔 Objective

This pr is to remove the email verification removal feature flag.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Logo
Checkmarx One – Scan Summary & Details13b20bf0-a15f-404b-8135-e8b39a068082

Fixed Issues (4)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /bitwarden_license/bit-web/src/app/tools/access-intelligence/org-at-risk-apps-dialog.component.html: 15
MEDIUM Client_Privacy_Violation /libs/tools/generator/components/src/username-generator.component.html: 3
MEDIUM Client_Privacy_Violation /libs/vault/src/components/download-attachment/download-attachment.component.ts: 29
MEDIUM Client_Privacy_Violation /libs/vault/src/components/download-attachment/download-attachment.component.ts: 29

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden force-pushed the auth/pm-7882/email-verification-removal-feature-flag branch 3 times, most recently from 5e52256 to 763f903 Compare January 6, 2025 22:17
@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden force-pushed the auth/pm-7882/email-verification-removal-feature-flag branch from 763f903 to 0a28e6a Compare January 6, 2025 22:18
…on - Fixed sso component to work with the test.
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 34.34%. Comparing base (7b496cc) to head (f7672e4).
Report is 39 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/browser/src/auth/popup/home.component.ts 0.00% 4 Missing ⚠️
apps/web/src/app/auth/login/login-v1.component.ts 0.00% 3 Missing ⚠️
...rgency-access/accept/accept-emergency.component.ts 0.00% 2 Missing ⚠️
...ganization-invite/accept-organization.component.ts 0.00% 2 Missing ⚠️
...sole/providers/manage/accept-provider.component.ts 0.00% 2 Missing ⚠️
.../angular/src/auth/components/login-v1.component.ts 0.00% 2 Missing ⚠️
apps/desktop/src/auth/login/login-v1.component.ts 0.00% 1 Missing ⚠️
...ponsorships/accept-family-sponsorship.component.ts 0.00% 1 Missing ⚠️
apps/web/src/app/oss-routing.module.ts 0.00% 1 Missing ⚠️
libs/auth/src/angular/sso/sso.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12718      +/-   ##
==========================================
- Coverage   34.38%   34.34%   -0.04%     
==========================================
  Files        2950     2975      +25     
  Lines       90416    90439      +23     
  Branches    16973    16928      -45     
==========================================
- Hits        31091    31065      -26     
- Misses      56861    56920      +59     
+ Partials     2464     2454      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Patrick-Pimentel-Bitwarden Patrick-Pimentel-Bitwarden marked this pull request as ready for review January 6, 2025 23:10
…on - Rolled back typesafe changes for a different pr.
audreyality
audreyality previously approved these changes Jan 8, 2025
…Fixed tests and other occurrences of the service.
jrmccannon
jrmccannon previously approved these changes Jan 9, 2025
@jrmccannon jrmccannon dismissed their stale review January 9, 2025 14:25

Didn't see the conflicts. sorry.

jrmccannon
jrmccannon previously approved these changes Jan 9, 2025
audreyality
audreyality previously approved these changes Jan 9, 2025
…on - Fixed up misguided routes and revisited some of the comments that were left behind.
audreyality

This comment was marked as resolved.

…Fixed some of the comments that got spliced.
@Patrick-Pimentel-Bitwarden
Copy link
Contributor Author

I'm sorry @rr-bw, I'm not sure what happened there and thanks @audreyality for the refresher for procedure.

Copy link
Contributor

@rr-bw rr-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this! Just two more changes.

…Update routing to restore functionality and added back in comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants