-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(email-verification-feature-flag): [PM-7882] Email Verificati… #12718
base: main
Are you sure you want to change the base?
refactor(email-verification-feature-flag): [PM-7882] Email Verificati… #12718
Conversation
…on - Removed email feature flag.
Fixed Issues (4)Great job! The following issues were fixed in this Pull Request
|
…on - Few more changes.
…on - Rolled back typo fixes.
5e52256
to
763f903
Compare
…on - Rolled back just a few more fixes.
763f903
to
0a28e6a
Compare
…on - Fixed sso component to work with the test.
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #12718 +/- ##
==========================================
- Coverage 34.38% 34.34% -0.04%
==========================================
Files 2950 2975 +25
Lines 90416 90439 +23
Branches 16973 16928 -45
==========================================
- Hits 31091 31065 -26
- Misses 56861 56920 +59
+ Partials 2464 2454 -10 ☔ View full report in Codecov by Sentry. |
…on - Rolled back typesafe changes for a different pr.
…on - Removed the feature flag.
…Fixed tests and other occurrences of the service.
…ation-removal-feature-flag
apps/web/src/app/auth/emergency-access/accept/accept-emergency.component.ts
Outdated
Show resolved
Hide resolved
.../web/src/app/admin-console/organizations/sponsorships/accept-family-sponsorship.component.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/auth/organization-invite/accept-organization.component.ts
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/admin-console/providers/manage/accept-provider.component.ts
Outdated
Show resolved
Hide resolved
…ation-removal-feature-flag
…on - Fixed up misguided routes and revisited some of the comments that were left behind.
6417c7f
apps/web/src/app/auth/emergency-access/accept/accept-emergency.component.ts
Outdated
Show resolved
Hide resolved
apps/web/src/app/auth/organization-invite/accept-organization.component.ts
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/admin-console/providers/manage/accept-provider.component.ts
Show resolved
Hide resolved
…Fixed some of the comments that got spliced.
I'm sorry @rr-bw, I'm not sure what happened there and thanks @audreyality for the refresher for procedure. |
…ation-removal-feature-flag
…ation-removal-feature-flag
…Updated comments to make more sense.
…on - Removed other code cleanups.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with this! Just two more changes.
apps/web/src/app/auth/organization-invite/accept-organization.component.ts
Outdated
Show resolved
Hide resolved
…Update routing to restore functionality and added back in comment.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-7326
📔 Objective
This pr is to remove the email verification removal feature flag.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes