Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(email-verification-feature-flag): [PM-7882] Email Verificati… #12718

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
98f45e9
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 6, 2025
a570803
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 6, 2025
84edfc0
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 6, 2025
0a28e6a
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 6, 2025
acb0931
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 6, 2025
ec28e7b
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 8, 2025
317c197
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 8, 2025
322ed11
fix(email-verification-feature-flag): [PM-7882] Email Verification - …
Patrick-Pimentel-Bitwarden Jan 8, 2025
a2b2d71
Merge remote-tracking branch 'origin' into auth/pm-7882/email-verific…
Patrick-Pimentel-Bitwarden Jan 9, 2025
a49ae00
Merge remote-tracking branch 'origin' into auth/pm-7882/email-verific…
Patrick-Pimentel-Bitwarden Jan 14, 2025
6417c7f
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 14, 2025
3e153ba
fix(email-verification-feature-flag): [PM-7882] Email Verification - …
Patrick-Pimentel-Bitwarden Jan 14, 2025
29f09a0
Merge remote-tracking branch 'origin' into auth/pm-7882/email-verific…
Patrick-Pimentel-Bitwarden Jan 15, 2025
454a798
Merge remote-tracking branch 'origin' into auth/pm-7882/email-verific…
Patrick-Pimentel-Bitwarden Jan 15, 2025
c57d38e
fix(email-verification-feature-flag): [PM-7882] Email Verification - …
Patrick-Pimentel-Bitwarden Jan 15, 2025
e8da9fa
refactor(email-verification-feature-flag): [PM-7882] Email Verificati…
Patrick-Pimentel-Bitwarden Jan 16, 2025
f7672e4
fix(email-verification-feature-flag): [PM-7882] Email Verification - …
Patrick-Pimentel-Bitwarden Jan 17, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,13 @@ export class AcceptFamilySponsorshipComponent extends BaseAcceptComponent {
if (!qParams.register) {
await this.router.navigate(["/login"], { queryParams: { email: qParams.email } });
} else {
// We have to override the base component route as we don't need users to
// complete email verification if they are coming directly an emailed invite.
// We don't need users to complete email verification if they are coming directly from an emailed invite.
// Therefore, we skip /signup and navigate directly to /finish-signup.

// TODO: in the future, to allow users to enter a name, consider sending all invite users to
// start registration page with prefilled email and a named token to be passed directly
// along to the finish-signup page without requiring email verification as
// we can treat the existence of the token as a form of email verification.

await this.router.navigate(["/finish-signup"], {
queryParams: {
email: qParams.email,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ export class AcceptEmergencyComponent extends BaseAcceptComponent {
}

async register() {
await this.router.navigate(["/signup"], {
// complete email verification if they are coming directly an emailed invite.
await this.router.navigate(["/finish-signup"], {
rr-bw marked this conversation as resolved.
Show resolved Hide resolved
queryParams: {
email: this.email,
acceptEmergencyAccessInviteToken: this.acceptEmergencyAccessInviteToken,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,8 @@ export class AcceptOrganizationComponent extends BaseAcceptComponent {
return;
}

// if SSO is disabled OR if sso is enabled but the SSO login required policy is not enabled
// then send user to create account
rr-bw marked this conversation as resolved.
Show resolved Hide resolved

await this.router.navigate(["/signup"], {
// complete email verification if they are coming directly an emailed invite.
await this.router.navigate(["/finish-signup"], {
rr-bw marked this conversation as resolved.
Show resolved Hide resolved
queryParams: {
email: invite.email,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export class AcceptProviderComponent extends BaseAcceptComponent {
}

async register() {
await this.router.navigate(["/signup"], {
await this.router.navigate(["/finish-signup"], {
rr-bw marked this conversation as resolved.
Show resolved Hide resolved
queryParams: {
email: this.email,
providerUserId: this.providerUserId,
Expand Down
Loading