Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SLNet_STORM_10100_it #718

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

bioimageiobot
Copy link
Collaborator

This is an automatic PR created by the @bioimageiobot regarding changes to the resource item 10.5281/zenodo.10659334.
The following version(s) will be added:

Please review the changes and make sure the new item or version(s) pass the following check list:

  • Passed the bioimage.io CI tests: static (and dynamic) validations
  • The meta information for the RDF item is complete
    • The tags are complete and describe the model
    • Naming is intuitive and descriptive, example: Multi-Organ Nucleus Segmentation (StarDist 2D)
    • Authors are provided
    • Documentation is complete
      • For models, include an overview, describe how the model is trained, what is the training data, how to use the model, how to validate the results and list the references. TODO: Model documentation template.
  • Approved by at least one of the bioimage.io admin team member.

Maintainers: none specified

Note: If you updated or re-uploaded another version for the current item on Zenodo, this PR won't be changed automatically. To proceed, you can do the following:

  1. Block this version, but keep looking for future versions: Edit the current resource.yaml and keep the top-level status field as accepted, but change the status under the current version to blocked.
  2. Accept this version and keep looking for future versions: Merge this PR for now.
  3. Keep proposed version(s) (and this resource in general if it is new) as pending: Close this PR without merging.

Then wait for the CI on the main branch to complete. It should detect the new version(s) and create another PR for the new version(s).

Previous PRs of this resource: none

@FynnBe
Copy link
Member

FynnBe commented Feb 21, 2024

Thank you for contributing @patrisvalera @pvjosue ( I hope I found the correct github accounts)!
I think I only have a few minor suggestions before accepting your model into the zoo...

Comment on lines +17 to +22
authors:
- name: 'Patris Valera'
github_user: patrisvalera
- name: 'Josue Page Vizcaino'
github_user: pvjosue
git_repo: https://github.com/pvjosue/SLNet_STORM
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patrisvalera @pvjosue are you ok with these additions?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello and thank you! Yes the additions are looking good.

@bioimageiobot
Copy link
Collaborator Author

@FynnBe FynnBe merged commit 31e22e6 into main Feb 21, 2024
8 checks passed
@FynnBe FynnBe deleted the auto-update-10.5281/zenodo.10659334 branch February 21, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants