Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gyro and magnetic custom alignment MSP #4294

Merged
merged 9 commits into from
Jan 10, 2025

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jan 4, 2025

BEFORE:

image

AFTER:

image

Two gyro's:

image

EDIT:

Last commit improves usability by disabling custom fields when preset is used, i.e. Custom is not selected.

image

@haslinghuis haslinghuis added this to the 11.0 milestone Jan 4, 2025
@haslinghuis haslinghuis self-assigned this Jan 4, 2025
Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 2a64ce1
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/678165d07a97260008e394f2
😎 Deploy Preview https://deploy-preview-4294.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis haslinghuis mentioned this pull request Jan 4, 2025
@haslinghuis haslinghuis force-pushed the custom-alignment branch 3 times, most recently from 281134e to 96dfc06 Compare January 6, 2025 22:48
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pre-approving for workflow, dependent on firmware PR-merge

@nerdCopter nerdCopter changed the title Custom alignment Add gyro and magnetic custom alignment MSP Jan 9, 2025
@limonspb
Copy link
Member

limonspb commented Jan 10, 2025

whats the difference between these two?
image

whats the use case for adjusting gyro alignment but not the board alignment if there is one gyro?

@haslinghuis
Copy link
Member Author

@limonspb we already have board_align, gyro_[12]_align

this PR

  • has not changed that beside putting them in separate boxes.
  • adds CUSTOM align element to GUI for gyro and magnetometer.
  • adds gyro_[12]_align_[RPY] and mag_align_[RPY]

@nerdCopter
Copy link
Member

nerdCopter commented Jan 10, 2025

question, pilot could always do either board or gyro with same result correct? i wonder if the UI should make it mutually exclusive where the pilot chooses "board" or chooses "gyro"(sensor) to display the specified fields (hiding the opposite). 🤷‍♂️
The separate boxes does add some confusion, which i did not consider until @limonspb reported.

edit: invalid comment, as it still need to show first/second/both and C[C]W[0-270] regardless.

@haslinghuis haslinghuis merged commit e5d9cfb into betaflight:master Jan 10, 2025
9 checks passed
@haslinghuis haslinghuis deleted the custom-alignment branch January 10, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants