-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Execute prettier #4291
Execute prettier #4291
Conversation
haslinghuis
commented
Jan 2, 2025
•
edited
Loading
edited
- run prettier once on the code base to minimize code changes in future PR's
- fix most of remaining sonar cloud issues in 2nd commit
- adds git blame ignore file for first commit
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not testing it 🤣
b7a9cc2
to
326589a
Compare
I like the idea of removing it from the git blame, similar to what would happen when AM32 gets re-formatted am32-firmware/AM32#138 |
a6f019e
to
683c096
Compare
I'm on the fence with doing it in bulk. What are the downsides? Causes rebasing requirement of existing PRs? Testing? What are the downsides to doing it as files are touched? |
@haslinghuis with the volume of changes to every file rebasing will be a pain. I'm not sure it will make reviewing files much harder... |
683c096
to
ec608a2
Compare
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
post-merge: flashed whoop, pasted diff, went to each tab pressed save; compared resultant diff to original = no change. great option to git-blame ignore 😃 |