-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tracing to the userprofile controller #1068
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
//------------------------------------------------------------------------- | ||
// Copyright © 2019 Province of British Columbia | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
//------------------------------------------------------------------------- | ||
|
||
namespace HealthGateway.Common.Utils | ||
{ | ||
using System; | ||
using System.Security.Claims; | ||
using Newtonsoft.Json; | ||
using Newtonsoft.Json.Linq; | ||
|
||
/// <summary> | ||
/// JsonConvert implementation that can handle Claim objects. | ||
/// </summary> | ||
public class JsonClaimConverter : JsonConverter | ||
{ | ||
/// <inheritdoc /> | ||
public override bool CanConvert(Type objectType) | ||
{ | ||
return objectType == typeof(Claim); | ||
} | ||
|
||
/// <inheritdoc /> | ||
public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer) | ||
{ | ||
var claim = (Claim)value; | ||
JObject jo = new JObject(); | ||
jo.Add("Type", claim.Type); | ||
jo.Add("Value", claim.Value); | ||
jo.Add("ValueType", claim.ValueType); | ||
jo.Add("Issuer", claim.Issuer); | ||
jo.Add("OriginalIssuer", claim.OriginalIssuer); | ||
jo.WriteTo(writer); | ||
} | ||
|
||
/// <inheritdoc /> | ||
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer) | ||
{ | ||
JObject jo = JObject.Load(reader); | ||
string type = (string)jo["Type"]; | ||
JToken token = jo["Value"]; | ||
string value = token.Type == JTokenType.String ? (string)token : token.ToString(Formatting.None); | ||
string valueType = (string)jo["ValueType"]; | ||
string issuer = (string)jo["Issuer"]; | ||
string originalIssuer = (string)jo["OriginalIssuer"]; | ||
return new Claim(type, value, valueType, issuer, originalIssuer); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
//------------------------------------------------------------------------- | ||
// Copyright © 2019 Province of British Columbia | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
//------------------------------------------------------------------------- | ||
|
||
namespace HealthGateway.Common.Utils | ||
{ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Security.Claims; | ||
using Newtonsoft.Json; | ||
using Newtonsoft.Json.Linq; | ||
|
||
/// <summary> | ||
/// JsonConvert implementation that can handle ClaimsIdentity objects. | ||
/// </summary> | ||
public class JsonClaimsIdentityConverter : JsonConverter | ||
{ | ||
/// <inheritdoc /> | ||
public override bool CanConvert(Type objectType) | ||
{ | ||
return typeof(ClaimsIdentity) == objectType; | ||
} | ||
|
||
/// <inheritdoc /> | ||
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer) | ||
{ | ||
var jObject = JObject.Load(reader); | ||
var claims = jObject[nameof(ClaimsIdentity.Claims)].ToObject<IEnumerable<Claim>>(serializer); | ||
var authenticationType = (string)jObject[nameof(ClaimsIdentity.AuthenticationType)]; | ||
var nameClaimType = (string)jObject[nameof(ClaimsIdentity.NameClaimType)]; | ||
var roleClaimType = (string)jObject[nameof(ClaimsIdentity.RoleClaimType)]; | ||
return new ClaimsIdentity(claims, authenticationType, nameClaimType, roleClaimType); | ||
} | ||
|
||
/// <inheritdoc /> | ||
public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer) | ||
{ | ||
var claimsIdentity = (ClaimsIdentity)value; | ||
var jObject = new JObject | ||
{ | ||
{ nameof(ClaimsIdentity.AuthenticationType), claimsIdentity.AuthenticationType }, | ||
{ nameof(ClaimsIdentity.IsAuthenticated), claimsIdentity.IsAuthenticated }, | ||
{ nameof(ClaimsIdentity.Actor), claimsIdentity.Actor == null ? null : JObject.FromObject(claimsIdentity.Actor, serializer) }, | ||
{ nameof(ClaimsIdentity.BootstrapContext), claimsIdentity.BootstrapContext == null ? null : JObject.FromObject(claimsIdentity.BootstrapContext, serializer) }, | ||
{ nameof(ClaimsIdentity.Claims), new JArray(claimsIdentity.Claims.Select(x => JObject.FromObject(x, serializer))) }, | ||
{ nameof(ClaimsIdentity.Label), claimsIdentity.Label }, | ||
{ nameof(ClaimsIdentity.Name), claimsIdentity.Name }, | ||
{ nameof(ClaimsIdentity.NameClaimType), claimsIdentity.NameClaimType }, | ||
{ nameof(ClaimsIdentity.RoleClaimType), claimsIdentity.RoleClaimType }, | ||
}; | ||
|
||
jObject.WriteTo(writer); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
//------------------------------------------------------------------------- | ||
// Copyright © 2019 Province of British Columbia | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
//------------------------------------------------------------------------- | ||
|
||
namespace HealthGateway.Common.Utils | ||
{ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Linq; | ||
using System.Security.Claims; | ||
using Newtonsoft.Json; | ||
using Newtonsoft.Json.Linq; | ||
|
||
/// <summary> | ||
/// JsonConvert implementation that can handle ClaimsPrincipal objects. | ||
/// </summary> | ||
public class JsonClaimsPrincipalConverter : JsonConverter | ||
{ | ||
/// <inheritdoc /> | ||
public override bool CanConvert(Type objectType) | ||
{ | ||
return typeof(ClaimsPrincipal) == objectType; | ||
} | ||
|
||
/// <inheritdoc /> | ||
public override object ReadJson(JsonReader reader, Type objectType, object existingValue, JsonSerializer serializer) | ||
{ | ||
var jObject = JObject.Load(reader); | ||
var identities = jObject[nameof(ClaimsPrincipal.Identities)].ToObject<IEnumerable<ClaimsIdentity>>(serializer); | ||
return new ClaimsPrincipal(identities); | ||
} | ||
|
||
/// <inheritdoc /> | ||
public override void WriteJson(JsonWriter writer, object value, JsonSerializer serializer) | ||
{ | ||
var claimsPrincipal = (ClaimsPrincipal)value; | ||
var jObject = new JObject | ||
{ | ||
{ nameof(ClaimsPrincipal.Identities), new JArray(claimsPrincipal.Identities.Select(x => JObject.FromObject(x, serializer))) }, | ||
}; | ||
|
||
jObject.WriteTo(writer); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So why do we need all of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately the claims serialization is not done by default (no default converters can do it). So these custom converters do the job.
Similar issues: codekoenig/AspNetCore.Identity.DocumentDb#22