Added tracing to the userprofile controller #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -109,6 +116,12 @@ public async Task<IActionResult> CreateUserProfile(string hdid, [FromBody] Creat | |||
| public IActionResult GetUserProfile(string hdid) | |||
| { | |||
| ClaimsPrincipal user = this.httpContextAccessor.HttpContext.User; | |||
| var jsonSettings = new JsonSerializerSettings() | |||
| { | |||
| Converters = new List<JsonConverter>() { new JsonClaimConverter(), new JsonClaimsPrincipalConverter(), new JsonClaimsIdentityConverter() }, | |||
There was a problem hiding this comment.
So why do we need all of this?
There was a problem hiding this comment.
unfortunately the claims serialization is not done by default (no default converters can do it). So these custom converters do the job.
Similar issues: codekoenig/AspNetCore.Identity.DocumentDb#22
tiagografiti
approved these changes
Oct 14, 2020
fixed |
sslaws
approved these changes
Oct 14, 2020
tiagografiti
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or Implements AB#9358
Status Ready
Description
Added logging to the user profile api. Added new object handlers for claim and identity serialization.
NetwonSoft needs to be used since the current version of .net serializer does not handle claims
https://www.thecodebuzz.com/jsonexception-possible-object-cycle-detected-object-depth/
Testing