Refactor app #34
Merged
Refactor app #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RogerKSI
approved these changes
Feb 25, 2025
tanut32039
reviewed
Feb 27, 2025
| return a.Store.SaveHashedPassphrase(hashedPassphrase) | ||
| // SavePassphrase hash the provided passphrase and save it into the application's store. | ||
| func (a *App) SavePassphrase(passphrase string) error { | ||
| a.Passphrase = passphrase |
There was a problem hiding this comment.
I think this line can be removed, a.Passphrase is not be used till the end.
tanut32039
reviewed
Feb 27, 2025
relayer/store/filesystem.go
Outdated
| return os.Write(fs.hashedPassphrase, getPassphrasePath(fs.HomePath)) | ||
| } | ||
|
|
||
| // ValidatePassphrase validates the given |
There was a problem hiding this comment.
sentence seems uncomplete
tanut32039
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
Implementation details
Please ensure the following requirements are met before submitting a pull request:
CHANGELOG_UNRELEASED.mdFiles changedtab in the Github PR explorer)