Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Improve tunnel penalty logic #31

Merged
merged 12 commits into from
Feb 20, 2025
Merged

[Feature] Improve tunnel penalty logic #31

merged 12 commits into from
Feb 20, 2025

Conversation

tanut32039
Copy link
Contributor

@tanut32039 tanut32039 commented Jan 31, 2025 •
edited
Loading

Fixed: #XXXX

Implementation details

  • Tunnel Relayer
    • Remove penalty channel (change to do on next xxx run instead)
    • Handle failed signing status of current group with incoming group success

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

nkitlabs
nkitlabs reviewed Feb 10, 2025
View reviewed changes
@RogerKSI RogerKSI requested a review from nkitlabs February 10, 2025 10:59
nkitlabs
nkitlabs reviewed Feb 11, 2025
View reviewed changes
relayer/tunnel_relayer.go Outdated
@@ -46,9 +46,14 @@ func NewTunnelRelayer(
}

// CheckAndRelay checks the tunnel and relays the packet
func (t *TunnelRelayer) CheckAndRelay(ctx context.Context) (err error) {
func (t *TunnelRelayer) CheckAndRelay(ctx context.Context) (err error, isExecuting bool) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch order hai noi (bool, error)

RogerKSI
RogerKSI approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@RogerKSI RogerKSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just fix the comment from @nkitlabs

Tanut Lertwarachai added 2 commits February 17, 2025 10:47
RogerKSI
RogerKSI reviewed Feb 19, 2025
View reviewed changes
@nkitlabs nkitlabs merged commit 2982260 into main Feb 20, 2025
2 checks passed
@nkitlabs nkitlabs deleted the tunnel-penalty-logic branch February 20, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerKSI RogerKSI RogerKSI approved these changes

@nkitlabs nkitlabs nkitlabs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanut32039 @RogerKSI @nkitlabs