[Feature] Add telemetry #27

tanut32039 · 2025-01-17T10:09:30Z

Fixed: #XXXX

Implementation details

Adding Falcon telemetry using Prometheus ref: https://docs.google.com/spreadsheets/d/1bMhwJbxXxFGT4GU1-ib5MgRl5nBXhLPdh9_wxoaY-B0/edit?gid=365016370#gid=365016370
Fix SyncTunnels logic

Please ensure the following requirements are met before submitting a pull request:

The pull request is targeted against the correct target branch
The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
The pull request includes a description of the implementation/work done in detail.
The pull request includes any and all appropriate unit/integration tests
You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

relayer/chains/evm/provider.go

internal/relayertest/testdata/default_config.toml

internal/relayertest/mocks/chain_provider.go

relayer/tunnel_relayer_test.go

dockerfile

relayer/scheduler.go

internal/relayermetrics/metrics.go

cmd/start.go

relayer/app.go

internal/relayermetrics/metrics.go

relayer/app.go

relayer/tunnel_relayer.go

relayer/scheduler.go

internal/relayermetrics/metrics.go

relayer/scheduler.go

relayer/app.go

relayer/scheduler.go

internal/relayermetrics/metrics.go

relayer/scheduler.go

internal/relayermetrics/metrics.go

nkitlabs · 2025-02-20T10:47:22Z

relayer/tunnel_relayer.go

+		// update the metric for unrelayed packets based on the difference between the latest sequences on BandChain and the target chain
+		relayermetrics.SetUnrelayedPackets(
+			t.TunnelID,
+			float64(tunnelBandInfo.LatestSequence-tunnelChainInfo.LatestSequence),


set twice? at the beginning & at the end?

nkitlabs · 2025-02-20T10:49:08Z

relayer/tunnel_relayer.go

+		// increment the packets received metric
+		relayermetrics.IncPacketsReceived(t.TunnelID)


what increment packet received for? new packet that falcon receive or successfully relayed?

change to PacketsRelayedSuccess pls check

relayer/scheduler.go

relayer/tunnel_relayer.go

relayer/scheduler.go

internal/relayermetrics/metrics.go

Tanut Lertwarachai added 2 commits January 17, 2025 17:02

add telemetry

189c4c5

Merge remote-tracking branch 'origin/main' into add-telemetry

92d242e

tanut32039 requested review from Kissadada, RogerKSI and nkitlabs January 17, 2025 10:09

change http to tcp

60db55a

nkitlabs reviewed Jan 26, 2025

View reviewed changes

relayer/chains/evm/provider.go Outdated Show resolved Hide resolved

nkitlabs reviewed Jan 26, 2025

View reviewed changes

internal/relayertest/testdata/default_config.toml Outdated Show resolved Hide resolved

Tanut Lertwarachai added 3 commits January 29, 2025 15:07

fix nil point

2373914

refac

e57efa5

add enable metric config

2ad6034

Kissadada reviewed Jan 31, 2025

View reviewed changes

internal/relayertest/mocks/chain_provider.go Outdated Show resolved Hide resolved

Kissadada reviewed Jan 31, 2025

View reviewed changes

relayer/tunnel_relayer_test.go Outdated Show resolved Hide resolved

rm comment

d40936b

RogerKSI requested review from Kissadada and nkitlabs January 31, 2025 13:44

RogerKSI reviewed Jan 31, 2025

View reviewed changes

dockerfile Outdated Show resolved Hide resolved

relayer/scheduler.go Outdated Show resolved Hide resolved

relayer/scheduler.go Outdated Show resolved Hide resolved

internal/relayermetrics/metrics.go Show resolved Hide resolved

Tanut Lertwarachai added 6 commits February 3, 2025 01:30

rm dockerfile

72c2de5

fix incorret synctunnels logic

a53be1b

refac metrics

c63c2d1

refac metrics

ba6e5ff

refac metrics

45cbbab

refac code

8912bcf

tanut32039 requested a review from RogerKSI February 4, 2025 04:01

nkitlabs reviewed Feb 4, 2025

View reviewed changes

Tanut Lertwarachai added 4 commits February 4, 2025 11:25

refac code

d9345a0

fix bug

a6c3f42

fix on comment

12d679d

rm inactive contract metrics

5fd0489

tanut32039 requested a review from nkitlabs February 6, 2025 07:45

RogerKSI requested changes Feb 11, 2025

View reviewed changes

Tanut Lertwarachai added 7 commits February 14, 2025 10:06

fix comment

1c9523f

fix comment

5c8f7da

refac sync

bee7589

refac

7b79a14

refac grammar

a7ad230

change ci-lint

f788e9e

rm aligncheck

258fd55

RogerKSI requested review from RogerKSI and nkitlabs February 19, 2025 08:32

RogerKSI requested changes Feb 19, 2025

View reviewed changes

internal/relayermetrics/metrics.go Outdated Show resolved Hide resolved

relayer/scheduler.go Outdated Show resolved Hide resolved

relayer/scheduler.go Outdated Show resolved Hide resolved

fix comment

0dd17ff

tanut32039 requested a review from RogerKSI February 19, 2025 10:44

fix conflict

7936e69

RogerKSI reviewed Feb 20, 2025

View reviewed changes

relayer/scheduler.go Outdated Show resolved Hide resolved

RogerKSI reviewed Feb 20, 2025

View reviewed changes

relayer/scheduler.go Outdated Show resolved Hide resolved

RogerKSI reviewed Feb 20, 2025

View reviewed changes

relayer/scheduler.go Outdated Show resolved Hide resolved

nkitlabs reviewed Feb 20, 2025

View reviewed changes

RogerKSI requested changes Feb 20, 2025

View reviewed changes

relayer/scheduler.go Outdated Show resolved Hide resolved

relayer/tunnel_relayer.go Outdated Show resolved Hide resolved

fix unused func

a515725

tanut32039 requested review from nkitlabs and RogerKSI February 20, 2025 18:15

nkitlabs reviewed Feb 21, 2025

View reviewed changes

relayer/scheduler.go Outdated Show resolved Hide resolved

relayer/scheduler.go Show resolved Hide resolved

internal/relayermetrics/metrics.go Outdated Show resolved Hide resolved

remove weird comment

21bf000

nkitlabs approved these changes Feb 21, 2025

View reviewed changes

tanut32039 requested a review from nkitlabs February 21, 2025 05:32

RogerKSI approved these changes Feb 21, 2025

View reviewed changes

nkitlabs approved these changes Feb 21, 2025

View reviewed changes

nkitlabs merged commit 59f1d30 into main Feb 21, 2025
2 checks passed

nkitlabs deleted the add-telemetry branch February 21, 2025 08:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Add telemetry #27

[Feature] Add telemetry #27

tanut32039 commented Jan 17, 2025 •

edited

Loading

nkitlabs Feb 20, 2025

tanut32039 Feb 21, 2025

nkitlabs Feb 20, 2025

tanut32039 Feb 21, 2025

		// increment the packets received metric
		relayermetrics.IncPacketsReceived(t.TunnelID)

[Feature] Add telemetry #27

[Feature] Add telemetry #27

Conversation

tanut32039 commented Jan 17, 2025 • edited Loading

Implementation details

Please ensure the following requirements are met before submitting a pull request:

nkitlabs Feb 20, 2025

Choose a reason for hiding this comment

tanut32039 Feb 21, 2025

Choose a reason for hiding this comment

nkitlabs Feb 20, 2025

Choose a reason for hiding this comment

tanut32039 Feb 21, 2025

Choose a reason for hiding this comment

tanut32039 commented Jan 17, 2025 •

edited

Loading