feat: block adding too unbalanced

packages/lib/modules/pool/actions/add-liquidity/AddLiquidityProvider.tsx

@@ -30,6 +30,7 @@ import { isUnhandledAddPriceImpactError } from '@repo/lib/modules/price-impact/p
 import { useModalWithPoolRedirect } from '../../useModalWithPoolRedirect'
 import { getPoolTokens } from '../../pool.helpers'
 import { useUserSettings } from '@repo/lib/modules/user/settings/UserSettingsProvider'
+import { isUnbalancedAddErrorMessage } from '@repo/lib/shared/utils/error-filters'
 
 export type UseAddLiquidityResponse = ReturnType<typeof _useAddLiquidity>
 export const AddLiquidityContext = createContext<UseAddLiquidityResponse | null>(null)
@@ -152,6 +153,7 @@ export function _useAddLiquidity(urlTxHash?: Hash) {
     [areEmptyAmounts(humanAmountsIn), 'You must specify one or more token amounts'],
     [hasValidationErrors, 'Errors in token inputs'],
     [needsToAcceptHighPI, 'Accept high price impact first'],
+    [isUnbalancedAddErrorMessage(priceImpactQuery.error), 'Unbalanced join'],
     [simulationQuery.isLoading, 'Fetching quote...'],
     [simulationQuery.isError, 'Error fetching quote'],
     [priceImpactQuery.isLoading, 'Fetching price impact...'],

packages/lib/modules/pool/actions/add-liquidity/form/AddLiquidityForm.tsx

@@ -87,6 +87,7 @@ function AddLiquidityMainForm() {
     proportionalSlippage,
     slippage,
     setProportionalSlippage,
+    humanAmountsIn,
   } = useAddLiquidity()
 
   const nextBtn = useRef(null)

packages/lib/modules/price-impact/price-impact.utils.ts

@@ -1,3 +1,4 @@
+import { isUnbalancedAddErrorMessage } from '@repo/lib/shared/utils/error-filters'
 import { bn } from '@repo/lib/shared/utils/numbers'
 import BigNumber from 'bignumber.js'
 
@@ -18,9 +19,12 @@ export function isUnhandledAddPriceImpactError(error: Error | null): boolean {
 }
 
 export function cannotCalculatePriceImpactError(error: Error | null): boolean {
-  if (error && error.name === 'ContractFunctionExecutionError') {
+  const hasUnbalancedAddError = isUnbalancedAddErrorMessage(error)
+
+  if (error && error.name === 'ContractFunctionExecutionError' && !hasUnbalancedAddError) {
     return true
   }
+
   return false
 }
 

packages/lib/shared/components/errors/GenericError.tsx

@@ -6,6 +6,7 @@ import {
   isNotEnoughGasError,
   isPausedError,
   isTooManyRequestsError,
+  isUnbalancedAddError,
   isUserRejectedError,
   isViemHttpFetchError,
 } from '../../utils/error-filters'
@@ -22,6 +23,7 @@ export function GenericError({ error: _error, customErrorName, ...rest }: Props)
   const error = ensureError(_error)
   if (isUserRejectedError(error)) return null
   const errorName = customErrorName ? `${customErrorName} (${error.name})` : error.name
+
   if (isViemHttpFetchError(_error)) {
     return (
       <ErrorAlert title={customErrorName} {...rest}>
@@ -34,6 +36,7 @@ export function GenericError({ error: _error, customErrorName, ...rest }: Props)
       </ErrorAlert>
     )
   }
+
   if (isPausedError(_error)) {
     return (
       <ErrorAlert title={customErrorName} {...rest}>
@@ -45,6 +48,7 @@ export function GenericError({ error: _error, customErrorName, ...rest }: Props)
       </ErrorAlert>
     )
   }
+
   if (isTooManyRequestsError(_error)) {
     return (
       <ErrorAlert title={customErrorName} {...rest}>
@@ -56,6 +60,7 @@ export function GenericError({ error: _error, customErrorName, ...rest }: Props)
       </ErrorAlert>
     )
   }
+
   if (isNotEnoughGasError(_error)) {
     return (
       <ErrorAlert title={customErrorName} {...rest}>
@@ -67,6 +72,17 @@ export function GenericError({ error: _error, customErrorName, ...rest }: Props)
       </ErrorAlert>
     )
   }
+
+  if (isUnbalancedAddError(_error)) {
+    return (
+      <ErrorAlert title={customErrorName} {...rest}>
+        <Text color="black" variant="secondary">
+          Your input(s) would excessively unbalance the pool. Please adjust to be more proportional.
+        </Text>
+      </ErrorAlert>
+    )
+  }
+
   const errorMessage = error?.shortMessage || error.message
 
   if (errorMessage === 'RPC Request failed.' || errorMessage === 'An unknown RPC error occurred.') {

packages/lib/shared/utils/error-filters.ts

@@ -44,3 +44,15 @@ export function isPausedError(error?: Error | null): boolean {
 export function isPausedErrorMessage(errorMessage: string): boolean {
   return errorMessage.includes('reverted with the following reason:\nBAL#402\n')
 }
+
+export function isUnbalancedAddError(error?: Error | null): boolean {
+  if (!error) return false
+  return isUnbalancedAddErrorMessage(error)
+}
+
+export function isUnbalancedAddErrorMessage(error: Error | null): boolean {
+  const errorStrings = ['BAL#304', 'queryAddLiquidityUnbalanced'] // [v2 error, v3 error]
+  const hasErrors = (errorString: string) => error?.message.includes(errorString)
+
+  return errorStrings.some(hasErrors)
+}