Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: block adding too unbalanced #92

Merged
merged 14 commits into from
Oct 24, 2024
Merged

feat: block adding too unbalanced #92

merged 14 commits into from
Oct 24, 2024

Conversation

groninge01
Copy link
Contributor

@groninge01 groninge01 commented Oct 22, 2024 •
edited
Loading

fixes #86

the issue is not only single sided adds but unbalanced adds in general
the specific error is BAL#304, when this error occurs it is intercepted and a msg is shown

image

@vercel Vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mono-beets-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:33am
mono-frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:33am
mono-test-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 8:33am

@groninge01 groninge01 marked this pull request as ready for review October 22, 2024 13:13
@garethfuller garethfuller requested a review from agualis October 22, 2024 15:42
agualis
agualis requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@agualis agualis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some other edge cases testing with big amounts. I will DM you tomorrow.

packages/lib/modules/pool/actions/add-liquidity/form/AddLiquidityForm.tsx Outdated Show resolved Hide resolved
@garethfuller garethfuller merged commit dcc14b3 into main Oct 24, 2024
8 checks passed
@garethfuller garethfuller deleted the feat/add-msg-for-bal-error-304 branch October 24, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethfuller garethfuller garethfuller approved these changes

@agualis agualis Awaiting requested review from agualis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable single-sided adds
3 participants
@groninge01 @agualis @garethfuller