Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate service/iot1clickdevicesservice and service/iot1clickprojects #2945

Merged
merged 3 commits into from
Jan 7, 2025
Merged

deprecate service/iot1clickdevicesservice and service/iot1clickprojects #2945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
526e74f
deprecate iot1click services
wty-Bryant Jan 6, 2025
d8a4306
add changelog
wty-Bryant Jan 6, 2025
0f8fb27
modify changelog
wty-Bryant Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changelog/82ce917a265846b68d6977bd88247343.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"id": "82ce917a-2658-46b6-8d69-77bd88247343",
"type": "feature",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit and not a blocker, but it seems weird to have "feature" for a deprecation :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just copied that from nimble deprecation pr

"description": "Mark service/iot1clickdevicesservice and service/iot1clickprojects as deprecated. Those 2 services are no longer available for use. See https://docs.aws.amazon.com/iot/latest/developerguide/iot-legacy-services.html#faq-1-click-eol",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kudos for adding the deprecation notice

"modules": [
"service/iot1clickdevicesservice",
"service/iot1clickprojects"
]
}
4 changes: 3 additions & 1 deletion ...n/src/main/java/software/amazon/smithy/aws/go/codegen/customization/DeprecateService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ public class DeprecateService implements GoIntegration {
private static final String DEPRECATION_MESSAGE =
"AWS has deprecated this service. It is no longer available for use.";
private static final Set<String> DEPRECATED = Set.of(
"com.amazonaws.nimble#nimble"
"com.amazonaws.nimble#nimble",
"com.amazonaws.iot1clickdevicesservice#IoT1ClickDevicesService",
"com.amazonaws.iot1clickprojects#AWSIoT1ClickProjects"
);

@Override
Expand Down
8 changes: 8 additions & 0 deletions service/iot1clickdevicesservice/api_op_ClaimDevicesByClaimCode.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions service/iot1clickdevicesservice/api_op_DescribeDevice.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions service/iot1clickdevicesservice/api_op_FinalizeDeviceClaim.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions service/iot1clickdevicesservice/api_op_GetDeviceMethods.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions service/iot1clickdevicesservice/api_op_InitiateDeviceClaim.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions service/iot1clickdevicesservice/api_op_InvokeDeviceMethod.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions service/iot1clickdevicesservice/api_op_ListDeviceEvents.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 12 additions & 0 deletions service/iot1clickdevicesservice/api_op_ListDevices.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions service/iot1clickdevicesservice/api_op_ListTagsForResource.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions service/iot1clickdevicesservice/api_op_TagResource.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions service/iot1clickdevicesservice/api_op_UnclaimDevice.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading