deprecate service/iot1clickdevicesservice and service/iot1clickprojects #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucix-aws
approved these changes
Jan 6, 2025
Madrigal
approved these changes
Jan 7, 2025
| @@ -0,0 +1,9 @@ | |||
| { | |||
| "id": "82ce917a-2658-46b6-8d69-77bd88247343", | |||
| "type": "feature", | |||
There was a problem hiding this comment.
nit and not a blocker, but it seems weird to have "feature" for a deprecation :P
There was a problem hiding this comment.
just copied that from nimble deprecation pr
| { | ||
| "id": "82ce917a-2658-46b6-8d69-77bd88247343", | ||
| "type": "feature", | ||
| "description": "Mark service/iot1clickdevicesservice and service/iot1clickprojects as deprecated. Those 2 services are no longer available for use. See https://docs.aws.amazon.com/iot/latest/developerguide/iot-legacy-services.html#faq-1-click-eol", |
There was a problem hiding this comment.
kudos for adding the deprecation notice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iot1clickdevicesservice and iot1clickprojects services will be deprecated, this PR pushes a final module update to add deprecation markers before actually removing the source.