-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume updated TaskResponse in network fault injection handlers #4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
951e8be
to
0d00215
Compare
xxx0624
reviewed
Aug 20, 2024
10de83f
to
4c3e41f
Compare
xxx0624
previously approved these changes
Aug 20, 2024
amogh09
reviewed
Aug 20, 2024
ae1fe16
to
8a595c4
Compare
xxx0624
previously approved these changes
Aug 20, 2024
f7b4cc0
to
ed4fcf1
Compare
xxx0624
previously approved these changes
Aug 27, 2024
49b31c8
to
456137e
Compare
456137e
to
c1ee70b
Compare
xxx0624
approved these changes
Aug 27, 2024
tshan2001
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will consume the
TaskResponse
changes that were introduced in #4285 and #4273 within the shared fault injection handlers. We will also be validating that the obtained task metadata for the corresponding incoming request for the following:FaultInjectionEnabled
?host
orawsvpc
network modeImplementation details
ecs-agent/tmds/handlers/fault/v1/handlers/handlers.go
getTaskMetadataForFault
to validate the obtained task metadata fromGetTaskMetadata
if it satisfy the 3 checks aboveagent/api/task/task.go
NetworkNamespace
andFaultInjectionEnabled
with corresponding getter methods. (Note: There will be a follow up PR to initialize/set these fields)agent/handlers/v4/tmdsstate.go
getTaskMetadata
to initializeFaultInjectionEnabled
and aTaskNetworkConfig
for theTaskResponse
object to be returned if the correspondingFaultInjectionEnabled
field of theTask
struct istrue
Testing
ecs-agent/tmds/handlers/fault/v1/handlers/handlers_test.go
for all three network fault injection handlers if:FaultInjectionEnabled
of TaskResponse is set to falseTaskNetworkConfig
of TaskResponse is emptyNetworkMode
of TaskNetworkConfig is set to an invalid valueagent/handlers/task_server_setup_test.go
for all three network fault injection if:FaultInjectionEnabled
of Task is set to falseNetworkMode
of Task is set to an invalid valueNew tests cover the changes: Yes
Description for the changelog
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.