Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shared handler for network latency fault #4300

Merged
merged 4 commits into from
Aug 21, 2024
Merged

Conversation

xxx0624
Copy link
Contributor

@xxx0624 xxx0624 commented Aug 19, 2024

Summary

This PR is to add a shared handler for network latency fault. Its implementation is not complete and will be worked on later.

Implementation details

Following the first handler, this PR is to -

  • Add three methods in ecs-agent/tmds/handlers/fault/v1/handlers/handlers.go for starting/stopping/checking network latency fault. Each of them will 1. parse the request payload 2. check if it's valid and 3. respond to the client accordingly.
  • Add a struct for the request of network latency fault in ecs-agent/tmds/handlers/fault/v1/types/types.go

Testing

New tests cover the changes:

Added unit test for StartNetworkLatency(), StopNetworkLatency(), and CheckNetworkLatency()

Description for the changelog

Feature: Add network latency handler

Additional Information

Does this PR include breaking model changes? If so, Have you added transformation functions?

Does this PR include the addition of new environment variables in the README?

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xxx0624 xxx0624 force-pushed the fis-handler branch 2 times, most recently from 704b6c1 to 962929b Compare August 19, 2024 23:39
@xxx0624 xxx0624 requested review from amogh09, mye956 and harishxr August 20, 2024 17:43
@xxx0624 xxx0624 marked this pull request as ready for review August 20, 2024 17:43
@xxx0624 xxx0624 requested a review from a team as a code owner August 20, 2024 17:43
@xxx0624 xxx0624 requested review from tshan2001 and removed request for harishxr August 20, 2024 22:35
@xxx0624 xxx0624 merged commit 2cfc68d into aws:dev Aug 21, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants