-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shared handler for network latency fault #4300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
704b6c1
to
962929b
Compare
amogh09
reviewed
Aug 20, 2024
mye956
reviewed
Aug 20, 2024
mye956
reviewed
Aug 20, 2024
amogh09
reviewed
Aug 20, 2024
mye956
approved these changes
Aug 20, 2024
tshan2001
approved these changes
Aug 21, 2024
amogh09
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to add a shared handler for network latency fault. Its implementation is not complete and will be worked on later.
Implementation details
Following the first handler, this PR is to -
ecs-agent/tmds/handlers/fault/v1/handlers/handlers.go
for starting/stopping/checking network latency fault. Each of them will 1. parse the request payload 2. check if it's valid and 3. respond to the client accordingly.ecs-agent/tmds/handlers/fault/v1/types/types.go
Testing
New tests cover the changes:
Added unit test for
StartNetworkLatency()
,StopNetworkLatency()
, andCheckNetworkLatency()
Description for the changelog
Feature: Add network latency handler
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.