feat(traffic_light_selector): add new node for traffic light selection #9721
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Jan 10, 2025 in 46s
CodeScene PR Check
✅ Code Health Quality Gates: OK
Code Health of new files: 9.53
- Declining Code Health: 3 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Method traffic_light_selector_node.cpp: TrafficLightSelectorNode::objectsCallback
- Complex Method utils.cpp: isInsideRoughRoi
- Bumpy Road Ahead traffic_light_selector_node.cpp: TrafficLightSelectorNode::objectsCallback
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
TrafficLightSelectorNode::objectsCallback has a cyclomatic complexity of 14, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
TrafficLightSelectorNode::objectsCallback has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check warning on line 44 in perception/autoware_traffic_light_selector/src/utils.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
isInsideRoughRoi has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Loading