Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traffic_light_selector): add new node for traffic light selection #9721

Merged

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Dec 23, 2024

Description

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Interface changes

Topic changes

Additions and removals

Change type Topic Type Topic Name Message Type Description
Added Pub output/traffic_light_rois tier4_perception_msgs/msg/TrafficLightRoiArray Selected traffic light for classification

Effects on system behavior

None.

Signed-off-by: badai-nguyen <[email protected]>

feat: add traffic ligth selector node

Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:require-cuda-build-and-test labels Dec 23, 2024
Copy link

github-actions bot commented Dec 23, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: badai-nguyen <[email protected]>
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Dec 23, 2024
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
@badai-nguyen badai-nguyen force-pushed the feat/traffic_light_selector branch from 6760c4f to 2c1214f Compare January 6, 2025 08:14
Signed-off-by: badai-nguyen <[email protected]>
@badai-nguyen badai-nguyen added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 6, 2025
Signed-off-by: badai-nguyen <[email protected]>
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 157 lines in your changes missing coverage. Please review.

Project coverage is 28.25%. Comparing base (7f9cdb6) to head (c5c4abd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...light_selector/src/traffic_light_selector_node.cpp 0.00% 79 Missing ⚠️
...tion/autoware_traffic_light_selector/src/utils.cpp 0.00% 64 Missing ⚠️
...tion/autoware_traffic_light_selector/src/utils.hpp 0.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9721      +/-   ##
==========================================
- Coverage   28.37%   28.25%   -0.13%     
==========================================
  Files        1485     1487       +2     
  Lines      111087   111222     +135     
  Branches    43148    43129      -19     
==========================================
- Hits        31521    31423      -98     
- Misses      76539    76663     +124     
- Partials     3027     3136     +109     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
differential-cuda 0.00% <0.00%> (?)
total 28.29% <ø> (-0.09%) ⬇️ Carriedforward from 8adce2b

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
@badai-nguyen badai-nguyen added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jan 14, 2025
Copy link
Contributor

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Foundamentally this package is okay but could you add maintainer me?

Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
@badai-nguyen badai-nguyen marked this pull request as ready for review January 23, 2025 03:00
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Copy link
Contributor

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@badai-nguyen
I am sorry, I had missed.
Could you change the include guard name like from UTILS_HPP_ to TRAFFIC_LIGHT_SELECTOR_UTILS_HPP_? ()
And I left some comments.

<arg name="input/camera_info" default="input/camera_info"/>
<arg name="traffic_light_selector_param_path" default="$(find-pkg-share autoware_traffic_light_selector)/config/traffic_light_selector.param.yaml"/>

<node pkg="autoware_traffic_light_selector" exec="traffic_light_selector_node" name="autoware_traffic_light_selector" output="screen">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<node pkg="autoware_traffic_light_selector" exec="traffic_light_selector_node" name="autoware_traffic_light_selector" output="screen">
<node pkg="autoware_traffic_light_selector" exec="traffic_light_selector_node" name="traffic_light_selector" output="screen">


{{json_to_markdown("perception/autoware_traffic_light_selector/schema/traffic_light_selector.schema.json")}}

N/A
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
N/A

@MasatoSaeki MasatoSaeki merged commit b59cd8d into autowarefoundation:main Feb 10, 2025
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:require-cuda-build-and-test type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants