-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(centerpoint, pointpainting): rearrange parameters for ML models and packages #6591
refactor(centerpoint, pointpainting): rearrange parameters for ML models and packages #6591
Conversation
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!!
perception/image_projection_based_fusion/config/pointpainting_ml_package.param.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6591 +/- ##
==========================================
- Coverage 14.93% 14.78% -0.16%
==========================================
Files 1944 1925 -19
Lines 134061 132724 -1337
Branches 39891 39521 -370
==========================================
- Hits 20027 19623 -404
+ Misses 91735 91127 -608
+ Partials 22299 21974 -325
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...perception_launch/launch/object_recognition/detection/detector/lidar_dnn_detector.launch.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
perception/image_projection_based_fusion/config/pointpainting_ml_package.param.yaml
Outdated
Show resolved
Hide resolved
@badai-nguyen |
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
@Shin-kyoto @knzo25 I have updated and rearrange some parameters. I also updated the logging_simulator testing results in |
perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: badai-nguyen <[email protected]>
f12cfd0
to
ad45a92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
3544601
to
70f4388
Compare
@Shin-kyoto BTW, I have merged autowarefoundation/autoware#4533 tested this change on Evaluator.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -0,0 +1,98 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@badai-nguyen This file has a wrong extension. (.schemal.json
)
Might be intentional too, I don't know.
Maybe related to autowarefoundation/autoware-github-actions#293
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xmfcx Thank you for your comment. It was my mistake. I will fix it.
…els and packages (autowarefoundation#6591) * refactor: lidar_centerpoint Signed-off-by: badai-nguyen <[email protected]> * refactor: pointpainting Signed-off-by: badai-nguyen <[email protected]> * chore: fix launch Signed-off-by: badai-nguyen <[email protected]> * chore: fix launch Signed-off-by: badai-nguyen <[email protected]> * chore: rearrange params Signed-off-by: badai-nguyen <[email protected]> * fix: json-schema-check error Signed-off-by: badai-nguyen <[email protected]> * fix: default param Signed-off-by: badai-nguyen <[email protected]> * refactor: rename param file Signed-off-by: badai-nguyen <[email protected]> * chore: typo Signed-off-by: badai-nguyen <[email protected]> * fix: align centerpoint param namespace with pointpainting Signed-off-by: badai-nguyen <[email protected]> * fix(centerpoint): add schema json Signed-off-by: badai-nguyen <[email protected]> * fix(pointpainting): fix schema json typo Signed-off-by: badai-nguyen <[email protected]> * style(pre-commit): autofix * docs: update pointpainting fusion doc Signed-off-by: badai-nguyen <[email protected]> * docs: update lidar centerpoint doc Signed-off-by: badai-nguyen <[email protected]> * fix: change omp param Signed-off-by: badai-nguyen <[email protected]> * fix:change twist and variance to model params Signed-off-by: badai-nguyen <[email protected]> * fix: keep build_only in launch Signed-off-by: badai-nguyen <[email protected]> * fix: schema check Signed-off-by: badai-nguyen <[email protected]> * chore: temporary remove schema required Signed-off-by: badai-nguyen <[email protected]> --------- Signed-off-by: badai-nguyen <[email protected]> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Releated Link
TIER IV INTERNAL LINK
Tests performed
autoware_data
directory by updatingautoware
and running./setup-dev-env.sh
fromautoware/
directory.logging_simulator
thatcenterpoint
orpointpainting
correctly reflect the parameters defined inautoware_launch
and indata_path
ros2 launch autoware_launch logging_simulator.launch.xml map_path:=$HOME/sample_autoware/sample-map vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit control:=false planning:=false perception:=true localization:=false perception_mode:=camera_lidar_fusion centerpoint_model_name:=centerpoint
Testing using centerpoint_tiny
ros2 launch autoware_launch logging_simulator.launch.xml map_path:=$HOME/sample_autoware/sample-map vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit control:=false planning:=false perception:=true localization:=false perception_mode:=camera_lidar_fusion centerpoint_model_name:=centerpoint_tiny
Tesing using pointpainting
ros2 launch autoware_launch logging_simulator.launch.xml map_path:=$HOME/sample_autoware/sample-map vehicle_model:=sample_vehicle sensor_model:=sample_sensor_kit control:=false planning:=false perception:=true localization:=false perception_mode:=camera_lidar_fusion lidar_detection_model:=pointpainting
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.