fix(bag_time_manager_rviz_plugin): update create_client API to use rc…

[esteve]

Description

rclcpp::create_client in rolling deprecated rmw_qos_profile_t in favor of the rclcpp::QoS API

Fixes #2782

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[taikitanaka3]

@esteve
thanks for pr, is this also tested by humble version？

[esteve]

@esteve
thanks for pr, is this also tested by humble version？

This PR should work with Humble, but I'm building it right now to check, I'll report with the results, don't approve it yet. Thanks.

[esteve]

@taikitanaka3 I fixed the latest commit because the changes were not building for Humble and lower.

[codecov]

Codecov Report

Base: 11.66% // Head: 11.66% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (6037d4a) compared to base (140a92b).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2783      +/-   ##
==========================================
- Coverage   11.66%   11.66%   -0.01%     
==========================================
  Files        1314     1314              
  Lines       91572    91593      +21     
  Branches    24366    24366              
==========================================
  Hits        10681    10681              
- Misses      69740    69761      +21     
  Partials    11151    11151              

Flag	Coverage Δ		*Carryforward flag
differential	0.00% <0.00%> (?)
total	11.66% <0.00%> (ø)		Carriedforward from c2705dd

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...manager_rviz_plugin/src/bag_time_manager_panel.cpp	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[taikitanaka3]

@esteve
can you take a look at this comment #2782 ?

[xmfcx]

@esteve I've made some changes to make maintenance costs minimum for this PR on following commit: c79c2b1

[esteve]

@xmfcx looks good, can you push it here? Thanks.