Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(iron): remove rmw_qos_profile_t #3809

Merged
merged 1 commit into from
May 25, 2023
Merged

build(iron): remove rmw_qos_profile_t #3809

merged 1 commit into from
May 25, 2023

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented May 24, 2023

Description

related to #2783 (comment)

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (98169fe) 14.11% compared to head (d9116bd) 14.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3809   +/-   ##
=======================================
  Coverage   14.11%   14.11%           
=======================================
  Files        1438     1438           
  Lines      101445   101426   -19     
  Branches    27021    27010   -11     
=======================================
+ Hits        14318    14320    +2     
+ Misses      71446    71426   -20     
+ Partials    15681    15680    -1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.12% <ø> (+<0.01%) ⬆️ Carriedforward from 6dc8617

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...manager_rviz_plugin/src/bag_time_manager_panel.cpp 0.00% <0.00%> (ø)
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp 0.00% <0.00%> (ø)
...tic_goal_rviz_plugin/src/automatic_goal_sender.cpp 0.00% <0.00%> (ø)
...ontrol_rviz_plugin/src/tools/manual_controller.cpp 0.00% <0.00%> (ø)
...er4_state_rviz_plugin/src/autoware_state_panel.cpp 0.00% <0.00%> (ø)
...troller/src/joy_controller/joy_controller_node.cpp 0.00% <0.00%> (ø)
...ization/ndt_scan_matcher/src/map_update_module.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 3.95% <ø> (+<0.01%) ⬆️
...de_manager/src/rtc_auto_mode_manager_interface.cpp 0.00% <0.00%> (ø)
planning/rtc_replayer/src/rtc_replayer_node.cpp 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wep21 wep21 merged commit 2ea192b into main May 25, 2023
@wep21 wep21 deleted the remove-rmw-qos-profile-t branch May 25, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:control Vehicle control algorithms and mechanisms. (auto-assigned) component:localization Vehicle's position determination in its environment. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants