Fix Latest CI failure due to Ubuntu 24 upgrade #484
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
GHA runners recently updated to Ubuntu 24 and caused a failure in latest CI. Not sure why this should matter as the error seems to pretty arbitrary:
After investigating a bit, I realized
web_test_case_spec
doesn't requirespec_helper
, adding this require resolves this issue. It seems to be that the glob order is different in Ubuntu 24 than 22, and my local, etc.CI:
Local:
Changelog
spec_helper
require withinspec/spec/web_test_case_spec.cr
framework
spec_helper requiresBefore merging, remember to add the
athena-framework/athena
prefix to the PR number in the PR title