Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Latest CI failure due to Ubuntu 24 upgrade #484

Merged
merged 9 commits into from
Dec 14, 2024
Merged

Fix Latest CI failure due to Ubuntu 24 upgrade #484

merged 9 commits into from
Dec 14, 2024

Conversation

Blacksmoke16
Copy link
Member

@Blacksmoke16 Blacksmoke16 commented Dec 14, 2024

Context

GHA runners recently updated to Ubuntu 24 and caused a failure in latest CI. Not sure why this should matter as the error seems to pretty arbitrary:

  Showing last frame. Use --error-trace for full trace.
  
  In src/components/framework/spec/spec/web_test_case_spec.cr:1:3
  
   1 | @[ASPEC::TestCase::Skip]
         ^--------------------
  Error: Error: undefined constant ASPEC::TestCase::Skip

After investigating a bit, I realized web_test_case_spec doesn't require spec_helper, adding this require resolves this issue. It seems to be that the glob order is different in Ubuntu 24 than 22, and my local, etc.

CI:
image

Local:
image

Changelog

  • Fix compiler error due to missing spec_helper require within spec/spec/web_test_case_spec.cr
  • Simplify framework spec_helper requires

Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title

@Blacksmoke16 Blacksmoke16 added kind:bug An existing feature isn't working as expected component:framework kind:specs labels Dec 14, 2024
@Blacksmoke16 Blacksmoke16 changed the title Try moving athena-spec require earlier Fix Latest CI failure due to Ubuntu 24 upgrade Dec 14, 2024
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Flag Coverage Δ
compiled 8.14% <ø> (ø)
unit 92.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
clock 98.18% <ø> (ø)
console 92.61% <ø> (ø)
dependency_injection 64.28% <ø> (ø)
dotenv 96.80% <ø> (ø)
event_dispatcher 82.75% <ø> (ø)
framework 94.16% <ø> (ø)
image_size 95.03% <ø> (ø)
mercure 93.37% <ø> (ø)
negotiation 97.69% <ø> (ø)
routing 92.96% <ø> (ø)
serializer 87.23% <ø> (ø)
spec 93.54% <ø> (ø)
validator 92.37% <ø> (ø)

📢 Thoughts on this report? Let us know!

@Blacksmoke16 Blacksmoke16 marked this pull request as ready for review December 14, 2024 16:53
@Blacksmoke16 Blacksmoke16 merged commit 5f517ca into master Dec 14, 2024
14 checks passed
@Blacksmoke16 Blacksmoke16 deleted the fix-ci branch December 14, 2024 16:55
PallasAthenaie pushed a commit to athena-framework/framework that referenced this pull request Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:framework kind:bug An existing feature isn't working as expected kind:specs
Development

Successfully merging this pull request may close these issues.

1 participant