Fix some incorrect exit codes when using scripts/test.sh
in some cases
#485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
While working on #484 I noticed that CI passed even when the spec was failing. This PR ensures the test script returns the proper exit code on failure in all cases.
Changelog
scripts/test.sh
in some casesBefore merging, remember to add the
athena-framework/athena
prefix to the PR number in the PR title