Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some incorrect exit codes when using scripts/test.sh in some cases #485

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

Blacksmoke16
Copy link
Member

Context

While working on #484 I noticed that CI passed even when the spec was failing. This PR ensures the test script returns the proper exit code on failure in all cases.

Changelog

  • Fix some incorrect exit codes when using scripts/test.sh in some cases

Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title

@Blacksmoke16 Blacksmoke16 added kind:bug An existing feature isn't working as expected component:ecosystem Affects all components in the ecosystem kind:infrastructure labels Dec 14, 2024
@Blacksmoke16 Blacksmoke16 merged commit c7fa026 into master Dec 14, 2024
12 checks passed
@Blacksmoke16 Blacksmoke16 deleted the fix-exit-code branch December 14, 2024 17:23
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
compiled 8.14% <ø> (ø)
unit 92.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
clock 98.18% <ø> (ø)
console 92.61% <ø> (ø)
dependency_injection 64.28% <ø> (ø)
dotenv 96.80% <ø> (ø)
event_dispatcher 82.75% <ø> (ø)
framework 94.16% <ø> (ø)
image_size 95.03% <ø> (ø)
mercure 93.37% <ø> (ø)
negotiation 97.69% <ø> (ø)
routing 92.96% <ø> (ø)
serializer 87.23% <ø> (ø)
spec 93.54% <ø> (ø)
validator 92.37% <ø> (ø)

📢 Thoughts on this report? Let us know!

@Blacksmoke16 Blacksmoke16 removed the component:ecosystem Affects all components in the ecosystem label Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug An existing feature isn't working as expected kind:infrastructure
Development

Successfully merging this pull request may close these issues.

1 participant