Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl fused future for Next #13

Closed
wants to merge 1 commit into from
Closed

impl fused future for Next #13

wants to merge 1 commit into from

Conversation

matklad
Copy link
Member

@matklad matklad commented Aug 13, 2019

This allows using st.next in select!

@skade
Copy link
Collaborator

skade commented Aug 13, 2019 •
edited
Loading

Builds currently fail on windows, but that's okay.

@matklad matklad mentioned this pull request Aug 14, 2019
Merged
@matklad matklad mentioned this pull request Aug 27, 2019
Open
@yoshuawuyts
Copy link
Contributor

If we switch to use #208 I wonder if this is still needed.

@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Sep 18, 2019
@matklad
Copy link
Member Author

matklad commented Sep 18, 2019

Probably not! It would be cool if we can live without fusing, as that’s super confusing. However, if we don’t merge this, perhaps we don’t need https://github.com/async-rs/async-std/pull/40/files either?

@yoshuawuyts
Copy link
Contributor

perhaps we don’t need https://github.com/async-rs/async-std/pull/40/files either

Oh yeah, we probably don't need it for sure, but given the patch was out and pretty much done I figured it wouldn't hurt to merge (for parity with Iterator::fuse!) Agreed fusing is confusing tho; and happy to reduce our usage of it as much as possible.

@yoshuawuyts yoshuawuyts mentioned this pull request Oct 29, 2019
Open
@yoshuawuyts
Copy link
Contributor

If we land #398 this PR will no longer be necessary, as we'd no longer use select! {} which in turn means no more fusing!

@ghost
Copy link

ghost commented Nov 2, 2019

Agree with @yoshuawuyts here. Let's close this.

@ghost ghost closed this Nov 2, 2019
@link2xt link2xt mentioned this pull request Oct 22, 2020
Open
moh-eulith pushed a commit to moh-eulith/async-std that referenced this pull request Mar 31, 2022
@Keruspe
reactor: properly reset registered wakers state when needed (async-rs#13
defb205 
)

If the list of pending wakers grew too big and we woke everything,
also drop the bit from wakers_registered

Signed-off-by: Marc-Antoine Perennou <[email protected]>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matklad @skade @yoshuawuyts