You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With #380 landed, we should update the tutorial to use them. This would remove the final dependency on futures-rs (and importantly: Sink) which should be a big step up in terms of usability.
Also we should consider moving from select! {} to Stream::merge. From chat with @skade we've figured out how to "send a close message after a stream has been exhausted":
@skade I'm assigning this to you as you've been working on updating this recently. Feel free to unassign yourself if you don't think you'll have bandwidth. Thanks!
cc me: I am slightly worried about introduction of explicit Shutdown messages, as opposed to just exhausting the stream. I wan to say that I want to port the tutorial myself, but I am in the middle of big refactoring of rust-analyzer right now. I'd be interested in reviewing the update PR!
With #380 landed, we should update the tutorial to use them. This would remove the final dependency on
futures-rs
(and importantly:Sink
) which should be a big step up in terms of usability.Also we should consider moving from
select! {}
toStream::merge
. From chat with @skade we've figured out how to "send aclose
message after a stream has been exhausted":@skade I'm assigning this to you as you've been working on updating this recently. Feel free to unassign yourself if you don't think you'll have bandwidth. Thanks!
edit: this would resolve #105 and #13
The text was updated successfully, but these errors were encountered: